Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injected CSS with insertCSS #16

Merged
merged 1 commit into from
Apr 15, 2014
Merged

Conversation

beaufortfrancois
Copy link
Contributor

Using insertCSS instead of executeScript seems to be proper.
Moreover, you may also want to remove "web_accessible_resources": [ "pesticide.min.css" ] from your manifest.

Using `insertCSS` instead of `executeScript` seems to be proper.
Moreover, you may also want to remove `"web_accessible_resources": [ "pesticide.min.css" ]` from your manifest.
@mrmrs
Copy link
Owner

mrmrs commented Apr 15, 2014

Awesome! thanks @beaufortfrancois

@mrmrs
Copy link
Owner

mrmrs commented Apr 15, 2014

@paulmolluzzo - merged this down to master. If you can double check everything and update the web store that would be great!

@mrmrs mrmrs merged commit 4998f85 into mrmrs:master Apr 15, 2014
@paulmolluzzo
Copy link
Contributor

@mrmrs This update removes a key feature: Toggling Pesticide.

In the version I wrote, you could show/hide Pesticide by clicking the extension icon. In @beaufortfrancois' update the toggling was removed and instead only turns Pesticide on; you have to refresh the page to remove Pesticide.

As it is now, I'd rather not push this update to the web store since it reduces half the functionality. If there's a better way to write any of the code that doesn't kill the toggling, I'm all for it. I have considered integrating a on/off version of the icon and updating it to make the ability to toggle more apparent.

@beaufortfrancois
Copy link
Contributor Author

Oh I didn't see that. Sorry.
It is indeed a bad move. executeScript is the way to go then.

@paulmolluzzo
Copy link
Contributor

No worries. I admit that it's tough to read through that ridiculous ternary.

mrmrs pushed a commit that referenced this pull request Jan 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants