Convert to Swift 2.0 syntax #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto converter probably should have caught these, oh well
This seems to be “in transition” in Swift/Cocoa, in a very annoying way. working with NSURL still requires a lot of the path methods from NSString, and since they are no longer bridged to String there is a lot of taking Strings (that were bridged from NSString to begin with) and bridging them right back to NSString to get access to those methods. The cleanest thing to do would be to just bridge all the path methods back into String, but since I suspect they will eventually go away so start migrating to the extra verbiage of dealing with NSURLs, which makes me sad because it’s moving further out of the Swift STDLIB and back into framework classes. Sigh. This also ends up with having to use NSURL.path! a lot, which I *really* don’t like… but I see no sane alternative yet.
much nicer for clean up long method with early return when have to unbind an optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just the conversion to get the project in it’s current WIP state to compile and run on the latest version of Xcode (7.0.1).
Better optimizations may come later.