-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add south gravity, overlays & uppercasing to loltext #304
Add south gravity, overlays & uppercasing to loltext #304
Conversation
* Fix config problem for default overlay_color * Animate stroke width always 1 (2 too thick for small image) * Animate pointsize is half of configured size (24 was half of default) * Interline spacing is negative, one-fifth of the configured size
This is awesome! nice work porting on those options. The new styling looks great and your PR looks all good to me too. Only thing is Travis CI seems to be failing on a couple of tests, i'll probably have some time tomorrow to help you out in getting this green before we can merge Also, for disabling the 💡- @mroth this gives me an idea on 'themes' for lolcommits - applied specifically to the |
Yeah I'm not sure how to pass the feature on 1.8/1.9 that is matching the YAML dump. On 1.8/1.9 the feature spec is adding /m to them and they're single quotes in 1.8/1.9 and always double quotes in 2.0+ |
OK, I took a look and managed to get a green build on Travis (all rubies) with these 2 commits; https://github.com/mroth/lolcommits/commits/south_gravity_and_overlays The main problem is down to the differences in how YAML represents arrays between the various Rubies. Can you port them to your changes and push here again, if all is green, then I'll merge your PR and get a gem release out soon. |
👍 done |
Great, merging now 👍 - Thanks again for your PR! |
Allows us to get to some real nice looking configurations.
This idea and code is adapted from @levibuzolic's fork that contains hipstertext
The config for these image was this: