-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use_frameworks! #191
Fix use_frameworks! #191
Conversation
This comment was marked as spam.
This comment was marked as spam.
Cool, thank you! |
Hmmm, I recently switched to use_frameworks and even with using this latest release, our build (of Gluroo -- Hi Marc!) gives:
|
It doesn’t seems like the version that you are using has my change, according to your error message.
…On 28 May 2024 at 1:03 PM -0400, Greg Badros ***@***.***>, wrote:
Hmmm, I recently switched to use_frameworks and even with using this latest release, our build (of Gluroo -- Hi Marc!) gives:
(/Users/greg/gp/gluroo/app/node_modules/react-native-blurhash/ios/BlurhashViewComponentView.mm:13:9)
11 | #import <react/renderer/components/blurhash_codegen/RCTComponentViewHelpers.h>
12 |
> 13 | #import "react_native_blurhash-Swift.h"
| ^ 'react_native_blurhash-Swift.h' file not found
14 |
15 | using namespace facebook::react;
16 |
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I see the change in the |
Actually, I think it was upgrading to 2.x that broke my iOS build because Android build is broken too. Seems the same as #190 |
@gjbadros I was able to build successfully on both platforms on the latest version using Expo 51, but that was without enabling the new architecture via the flag. |
hey greg! hmmm, so new arch breaks after this? |
Yes, that's true for our build. I can confirm that upgrading to 2.x broke both builds with the new architecture turned on (adding I've also just confirmed that I can upgrade to 2.x without the new architecture and Expo SDK 51 and have the build complete (haven't tested yet really). |
If a project uses dynamic frameworks on iOS, projects that include this library will not compile. This PR fixes that issue.
Fixes #188