feat: Reanimated v3 support in RNVisionCamera v2 #1759

tomekzaw · 2023-09-04T11:58:09Z

What

This PR makes it possible to use RNVisionCamera v2 with Reanimated v3 (3.5.0+) 🥳

I've branched off from @mrousavy's PR (#1623) which bumps react-native version in the example app as well as does some general cleanup and integrated Reanimated v3 on top of it.

Changes

Move Camera thread runtime creation from C++ to JS using Reanimated.createWorkletRuntime
Call worklets using WorkletRuntime::runGuarded which already supports error handling
Consume Reanimated as a prefab instead of from AARs and node_modules
Decouple VisionCameraScheduler from Reanimated internals

Demo

iOS demo: https://twitter.com/tomekzaw_/status/1697302708879765983

IMG_3318.mp4

Android demo: https://twitter.com/tomekzaw_/status/1697604643365278077

android.mp4

Tested on

Apple iPhone 13 Pro (device)
Google Pixel 7 Pro (emulator)

Related issues

…lude_directories` in CMakeLists.txt

…radle Sync issue

mrousavy · 2023-09-06T09:53:36Z

I think the CI is just tweaking because of the new arch, probably needs to be updated

mrousavy · 2023-09-18T13:27:40Z

LGTM!!!!!!!! @tomekzaw ❤️ 🚀

stevepepple · 2023-09-18T15:52:44Z

Thank you!

efstathiosntonas · 2023-09-18T15:54:55Z

hey @tomekzaw, fantastic work, thank you.

I'm using rean@3.5.2 and I get 'WorkletRuntime.h' file not found on FrameProcessorUtils.h. I've tried everything, deintegrate pods, delete node_modules, derived data and build folder. I'm using xcode 15.

note 1:
I have to use this:

use_frameworks! :linkage => :static # firebase 

	installer.pods_project.targets.each do |target|
			target.build_configurations.each do |config|
				target.build_settings(config.name)['CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES'] = 'YES'
				config.build_settings['HEADER_SEARCH_PATHS'] ||= '$(inherited) '
                config.build_settings['HEADER_SEARCH_PATHS'] << '"${PODS_ROOT}/../../node_modules/react-native/ReactCommon"'
			end
		end

otherwise I get this error: 'react/bridging/CallbackWrapper.h' file not found

note 2:
I have disabled frame processor on podfile: $VCDisableFrameProcessors = true since I don't use it.

Let me know if you want me to open an issue.

short-dsb · 2023-09-18T19:24:18Z

Yes, @tomekzaw thanks for all your work. 🙂

Unfortunately, I’m unable to build on Android after this change (v2.15.6 works as intended).

First, had to add react-native-reanimated as a dependency of my project:

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/dsb/quicksilver-app/node_modules/react-native-vision-camera/android/build.gradle' line: 290

* What went wrong:
A problem occurred evaluating project ':react-native-vision-camera'.
> Project with path ':react-native-reanimated' could not be found in project ':react-native-vision-camera'.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 19s
error Failed to install the app.

After that, the build still failed:

> Task :react-native-vision-camera:buildCMakeDebug[arm64-v8a] FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/8.0.1/userguide/command_line_interface.html#sec:command_line_warnings
553 actionable tasks: 61 executed, 492 up-to-date

info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor

Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-vision-camera:buildCMakeDebug[arm64-v8a]'.
> com.android.ide.common.process.ProcessException: ninja: Entering directory `/Users/<username>/<appname>/node_modules/react-native-vision-camera/android/.cxx/Debug/5g6w2027/arm64-v8a'
  [1/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JHashMap.cpp.o
  [2/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JImageProxy.cpp.o
  [3/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JFrameProcessorPlugin.cpp.o
  [4/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCameraScheduler.cpp.o
  [5/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCamera.cpp.o
  [6/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/FrameHostObject.cpp.o
  [7/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o
  FAILED: CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o
  /Users/<username>/Library/Android/sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ --target=aarch64-none-linux-android21 --sysroot=/Users/<username>/Library/Android/sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot -DVisionCamera_EXPORTS -I/Users/<username>/<appname>/node_modules/react-native/ReactAndroid/src/main/jni/react/turbomodule -I/Users/<username>/<appname>/node_modules/react-native/ReactCommon -I/Users/<username>/<appname>/node_modules/react-native/ReactCommon/callinvoker -I/Users/<username>/<appname>/node_modules/react-native/ReactCommon/jsi -I/Users/<username>/<appname>/node_modules/react-native/ReactCommon/react/renderer/graphics/platform/cxx -I/Users/<username>/<appname>/node_modules/react-native/ReactCommon/runtimeexecutor -I/Users/<username>/<appname>/node_modules/react-native/ReactCommon/yoga -I/Users/<username>/<appname>/node_modules/react-native-vision-camera/android/src/main/cpp -isystem /Users/<username>/.gradle/caches/transforms-3/cfd05174db796e6ba52a28c79bfef831/transformed/jetified-hermes-android-0.72.4-debug/prefab/modules/libhermes/include -isystem /Users/<username>/.gradle/caches/transforms-3/60c3c08fca978423e3d72b1faf27e6b1/transformed/jetified-react-android-0.72.4-debug/prefab/modules/folly_runtime/include -isystem /Users/<username>/.gradle/caches/transforms-3/60c3c08fca978423e3d72b1faf27e6b1/transformed/jetified-react-android-0.72.4-debug/prefab/modules/glog/include -isystem /Users/<username>/.gradle/caches/transforms-3/60c3c08fca978423e3d72b1faf27e6b1/transformed/jetified-react-android-0.72.4-debug/prefab/modules/jsi/include -isystem /Users/<username>/.gradle/caches/transforms-3/60c3c08fca978423e3d72b1faf27e6b1/transformed/jetified-react-android-0.72.4-debug/prefab/modules/reactnativejni/include -isystem /Users/<username>/.gradle/caches/transforms-3/55bb60e467db9b157eeac503afe480dd/transformed/jetified-fbjni-0.3.0/prefab/modules/fbjni/include -isystem /Users/<username>/<appname>/node_modules/react-native-reanimated/android/build/prefab-headers/reanimated -fexceptions -frtti -std=c++1y -DONANDROID -DFOR_HERMES=1 -g  -fno-limit-debug-info -fPIC -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DFOLLY_HAVE_RECVMMSG=1 -DFOLLY_HAVE_PTHREAD=1 -DFOLLY_HAVE_XSI_STRERROR_R=1 -MD -MT CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o -MF CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o.d -o CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o -c /Users/<username>/<appname>/node_modules/react-native-vision-camera/android/src/main/cpp/JSIJNIConversion.cpp
  In file included from /Users/<username>/<appname>/node_modules/react-native-vision-camera/android/src/main/cpp/JSIJNIConversion.cpp:17:
  /Users/<username>/.gradle/caches/transforms-3/60c3c08fca978423e3d72b1faf27e6b1/transformed/jetified-react-android-0.72.4-debug/prefab/modules/reactnativejni/include/react/jni/ReadableNativeMap.h:41:3: error: no template named 'optional' in namespace 'std'; did you mean 'folly::Optional'?
    std::optional<folly::dynamic> keys_;
    ^~~~~
  /Users/<username>/.gradle/caches/transforms-3/60c3c08fca978423e3d72b1faf27e6b1/transformed/jetified-react-android-0.72.4-debug/prefab/modules/folly_runtime/include/folly/Optional.h:102:7: note: 'folly::Optional' declared here
  class Optional {
        ^
  1 error generated.
  [8/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/CameraView.cpp.o
  [9/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o
  ninja: build stopped: subcommand failed.

  C++ build system [build] failed while executing:
      /Users/<username>/Library/Android/sdk/cmake/3.22.1/bin/ninja \
        -C \
        /Users/<username>/<appname>/node_modules/react-native-vision-camera/android/.cxx/Debug/5g6w2027/arm64-v8a \
        VisionCamera
    from /Users/<username>/<appname>/node_modules/react-native-vision-camera/android

Didn’t try iOS. Likewise to the above comment, please let me know if you’d like me to open an issue.

tomekzaw · 2023-09-19T03:18:02Z

Hey @efstathiosntonas and @short-dsb, thanks for testing out the changes! Could you please check if these PRs resolve your issues?

efstathiosntonas · 2023-09-19T05:20:48Z

@tomekzaw works as a charm on iOS, on Android I get this: (rn@0.72.4, kotlinVersion: 1.8.22)

e: The Android extensions ('kotlin-android-extensions') compiler plugin is no longer supported. Please use kotlin parcelize and view binding. More information: https://goo.gle/kotlin-android-extensions-deprecation

edit:

If I disable VisionCamera_disableFrameProcessors=true it also throws this now (I've applied both patches from above, I don't know why it complains about clang-14):

efstathiosntonas · 2023-09-19T06:05:39Z

@tomekzaw after commenting out these lines it builts successfully on Android (at least on my setup):

mrousavy · 2023-09-19T06:59:20Z

Ah whoops yea I forgot that this should still be optional, my bad.

Do we not need the kotlin extensions? Lemme try to build without

vadbertalan · 2023-10-02T09:21:09Z

Hi! @tomekzaw and @mrousavy thank you for this PR. Unfortunately I'm getting the following error Assertion failed: (object->ctx_ == ctx_ && "Don't try to clone an object backed by a different Runtime"), function cloneObject, file JSCRuntime.cpp, line 643. when the camera and the frame processor is started.

Am I doing something wrong? Do you guys have any idea how to solve this?

		"react-native": "0.72.4",
		"react-native-reanimated": "3.5.4",
		"react-native-vision-camera": "2.16.1",
		"vision-camera-code-scanner": "0.2.0"

tomekzaw · 2023-10-02T13:01:31Z

@vadbertalan Thanks for reporting this problem. Just out of curiosity, could you please check if the issue persists when Hermes is enabled (instead of JSC)?

vadbertalan · 2023-10-02T15:07:36Z

@tomekzaw I can confirm that this is a JSC only crash. By enabling Hermes, the frame processor is providing the frames as intended.

denisbevilacqua · 2023-10-03T11:12:35Z

Hi! After cleaning the Android project, we get the next error:

Execution failed for task ':react-native-vision-camera:buildCMakeDebug[arm64-v8a]'.
> com.android.ide.common.process.ProcessException: ninja: Entering directory `/Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android/.cxx/Debug/1t3p5vh3/arm64-v8a'
  [1/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JHashMap.cpp.o
  [2/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JFrameProcessorPlugin.cpp.o
  [3/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JImageProxy.cpp.o
  [4/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCameraScheduler.cpp.o
  [5/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCamera.cpp.o
  [6/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/FrameHostObject.cpp.o
  [7/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o
  [8/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/CameraView.cpp.o
  [9/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o
  [10/10] Linking CXX shared library ../../../../build/intermediates/cxx/Debug/1t3p5vh3/obj/arm64-v8a/libVisionCamera.so
  FAILED: ../../../../build/intermediates/cxx/Debug/1t3p5vh3/obj/arm64-v8a/libVisionCamera.so
  : &&

However, if we change the Reanimated version to a different one (e.g., from 3.5.3 to 3.5.4) after encountering the build failure and then rebuild the project, the app compiles successfully.

We are using:

"react-native": "^0.72.5",
"react-native-vision-camera": "2.16.1",
"react-native-worklets-core": "^0.2.0",
"vision-camera-code-scanner": "^0.2.0",
"react-native-reanimated": "3.5.3",

@tomekzaw @mrousavy , do you have any insights into what might be causing this issue?

tomekzaw · 2023-10-03T12:15:53Z

@denisbevilacqua What's the actual error? It seems like there should be some more info after "Linking CXX shared library"

denisbevilacqua · 2023-10-03T12:21:35Z

@tomekzaw Yes, I'm sorry, the complete error is:

> Task :react-native-vision-camera:configureCMakeDebug[arm64-v8a]
C/C++: CMake Warning at CMakeLists.txt:216 (message):
C/C++:   VisionCamera linking: FOR_HERMES=true

> Task :react-native-vision-camera:buildCMakeDebug[arm64-v8a] FAILED
C/C++: ninja: Entering directory `/Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android/.cxx/Debug/93z355m5/arm64-v8a'
C/C++: ld: error: undefined symbol: reanimated::extractWorkletRuntime(facebook::jsi::Runtime&, facebook::jsi::Value const&)
C/C++: ld: error: undefined symbol: reanimated::extractShareableOrThrow(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&)
C/C++: ld: error: undefined symbol: typeinfo for reanimated::Shareable
C/C++: ld: error: undefined symbol: typeinfo for reanimated::ShareableWorklet
C/C++: clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
w: Detected multiple Kotlin daemon sessions at build/kotlin/sessions

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/8.0.1/userguide/command_line_interface.html#sec:command_line_warnings
229 actionable tasks: 222 executed, 7 up-to-date

info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor

Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/VirtualView.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vector-icons/android/src/newarch/java/com/oblador/vectoricons/VectorIconsModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-vision-camera:buildCMakeDebug[arm64-v8a]'.
> com.android.ide.common.process.ProcessException: ninja: Entering directory `/Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android/.cxx/Debug/93z355m5/arm64-v8a'
  [1/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JHashMap.cpp.o
  [2/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JImageProxy.cpp.o
  [3/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JFrameProcessorPlugin.cpp.o
  [4/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCameraScheduler.cpp.o
  [5/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCamera.cpp.o
  [6/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/FrameHostObject.cpp.o
  [7/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/CameraView.cpp.o
  [8/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o
  [9/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o
  [10/10] Linking CXX shared library ../../../../build/intermediates/cxx/Debug/93z355m5/obj/arm64-v8a/libVisionCamera.so
  FAILED: ../../../../build/intermediates/cxx/Debug/93z355m5/obj/arm64-v8a/libVisionCamera.so
  : && /Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ --target=aarch64-none-linux-android26 --sysroot=/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot -fPIC -fexceptions -frtti -std=c++1y -DONANDROID -DFOR_HERMES=1 -g  -fno-limit-debug-info  -Wl,--build-id=sha1 -Wl,--no-rosegment -Wl,--fatal-warnings -Qunused-arguments -Wl,--no-undefined -shared -Wl,-soname,libVisionCamera.so -o ../../../../build/intermediates/cxx/Debug/93z355m5/obj/arm64-v8a/libVisionCamera.so CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCamera.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/FrameHostObject.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/CameraView.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCameraScheduler.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JFrameProcessorPlugin.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JImageProxy.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JHashMap.cpp.o  /Users/denisbevilacqua/.gradle/caches/transforms-3/6e906ae11a9e62f178ac1fed272cf94e/transformed/jetified-hermes-android-0.72.5-debug/prefab/modules/libhermes/libs/android.arm64-v8a/libhermes.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/18e790de7d60dccd07e3a88da530f5b8/transformed/jetified-react-android-0.72.5-debug/prefab/modules/folly_runtime/libs/android.arm64-v8a/libfolly_runtime.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/18e790de7d60dccd07e3a88da530f5b8/transformed/jetified-react-android-0.72.5-debug/prefab/modules/glog/libs/android.arm64-v8a/libglog.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/18e790de7d60dccd07e3a88da530f5b8/transformed/jetified-react-android-0.72.5-debug/prefab/modules/jsi/libs/android.arm64-v8a/libjsi.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/18e790de7d60dccd07e3a88da530f5b8/transformed/jetified-react-android-0.72.5-debug/prefab/modules/reactnativejni/libs/android.arm64-v8a/libreactnativejni.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/34c2120d0d3cd8dc97826fc02c9e8fc4/transformed/jetified-fbjni-0.3.0/prefab/modules/fbjni/libs/android.arm64-v8a/libfbjni.so  /Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/lib/aarch64-linux-android/26/liblog.so  -landroid   -latomic -lm && :
  ld: error: undefined symbol: reanimated::extractWorkletRuntime(facebook::jsi::Runtime&, facebook::jsi::Value const&)
  >>> referenced by FrameProcessorRuntimeManager.cpp:105 (/Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android/src/main/cpp/FrameProcessorRuntimeManager.cpp:105)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(vision::FrameProcessorRuntimeManager::setFrameProcessor(facebook::jsi::Runtime&, int, facebook::jsi::Value const&, facebook::jsi::Value const&))

  ld: error: undefined symbol: reanimated::extractShareableOrThrow(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&)
  >>> referenced by Shareables.h:163 (/Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-reanimated/android/build/prefab-headers/reanimated/Shareables.h:163)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::shared_ptr<reanimated::ShareableWorklet> reanimated::extractShareableOrThrow<reanimated::ShareableWorklet>(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&))

  ld: error: undefined symbol: typeinfo for reanimated::Shareable
  >>> referenced by memory:0 (/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/memory:0)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::enable_if<(!(is_array<reanimated::ShareableWorklet>::value)) && (!(is_array<reanimated::Shareable>::value)), std::__ndk1::shared_ptr<reanimated::ShareableWorklet> >::type std::__ndk1::dynamic_pointer_cast<reanimated::ShareableWorklet, reanimated::Shareable>(std::__ndk1::shared_ptr<reanimated::Shareable> const&))
  >>> referenced by memory:0 (/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/memory:0)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::enable_if<(!(is_array<reanimated::ShareableWorklet>::value)) && (!(is_array<reanimated::Shareable>::value)), std::__ndk1::shared_ptr<reanimated::ShareableWorklet> >::type std::__ndk1::dynamic_pointer_cast<reanimated::ShareableWorklet, reanimated::Shareable>(std::__ndk1::shared_ptr<reanimated::Shareable> const&))

  ld: error: undefined symbol: typeinfo for reanimated::ShareableWorklet
  >>> referenced by memory:0 (/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/memory:0)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::enable_if<(!(is_array<reanimated::ShareableWorklet>::value)) && (!(is_array<reanimated::Shareable>::value)), std::__ndk1::shared_ptr<reanimated::ShareableWorklet> >::type std::__ndk1::dynamic_pointer_cast<reanimated::ShareableWorklet, reanimated::Shareable>(std::__ndk1::shared_ptr<reanimated::Shareable> const&))
  >>> referenced by memory:0 (/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/memory:0)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::enable_if<(!(is_array<reanimated::ShareableWorklet>::value)) && (!(is_array<reanimated::Shareable>::value)), std::__ndk1::shared_ptr<reanimated::ShareableWorklet> >::type std::__ndk1::dynamic_pointer_cast<reanimated::ShareableWorklet, reanimated::Shareable>(std::__ndk1::shared_ptr<reanimated::Shareable> const&))
  clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
  ninja: build stopped: subcommand failed.

  C++ build system [build] failed while executing:
      /Users/denisbevilacqua/Library/Android/Sdk/cmake/3.22.1/bin/ninja \
        -C \
        /Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android/.cxx/Debug/93z355m5/arm64-v8a \
        VisionCamera
    from /Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1m 57s

denisbevilacqua · 2023-10-04T15:38:54Z

@tomekzaw Yes, I'm sorry, the complete error is:

> Task :react-native-vision-camera:configureCMakeDebug[arm64-v8a]
C/C++: CMake Warning at CMakeLists.txt:216 (message):
C/C++:   VisionCamera linking: FOR_HERMES=true

> Task :react-native-vision-camera:buildCMakeDebug[arm64-v8a] FAILED
C/C++: ninja: Entering directory `/Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android/.cxx/Debug/93z355m5/arm64-v8a'
C/C++: ld: error: undefined symbol: reanimated::extractWorkletRuntime(facebook::jsi::Runtime&, facebook::jsi::Value const&)
C/C++: ld: error: undefined symbol: reanimated::extractShareableOrThrow(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&)
C/C++: ld: error: undefined symbol: typeinfo for reanimated::Shareable
C/C++: ld: error: undefined symbol: typeinfo for reanimated::ShareableWorklet
C/C++: clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
w: Detected multiple Kotlin daemon sessions at build/kotlin/sessions

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/8.0.1/userguide/command_line_interface.html#sec:command_line_warnings
229 actionable tasks: 222 executed, 7 up-to-date

info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor

Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/VirtualView.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vector-icons/android/src/newarch/java/com/oblador/vectoricons/VectorIconsModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-vision-camera:buildCMakeDebug[arm64-v8a]'.
> com.android.ide.common.process.ProcessException: ninja: Entering directory `/Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android/.cxx/Debug/93z355m5/arm64-v8a'
  [1/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JHashMap.cpp.o
  [2/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JImageProxy.cpp.o
  [3/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JFrameProcessorPlugin.cpp.o
  [4/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCameraScheduler.cpp.o
  [5/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCamera.cpp.o
  [6/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/FrameHostObject.cpp.o
  [7/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/CameraView.cpp.o
  [8/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o
  [9/10] Building CXX object CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o
  [10/10] Linking CXX shared library ../../../../build/intermediates/cxx/Debug/93z355m5/obj/arm64-v8a/libVisionCamera.so
  FAILED: ../../../../build/intermediates/cxx/Debug/93z355m5/obj/arm64-v8a/libVisionCamera.so
  : && /Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ --target=aarch64-none-linux-android26 --sysroot=/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot -fPIC -fexceptions -frtti -std=c++1y -DONANDROID -DFOR_HERMES=1 -g  -fno-limit-debug-info  -Wl,--build-id=sha1 -Wl,--no-rosegment -Wl,--fatal-warnings -Qunused-arguments -Wl,--no-undefined -shared -Wl,-soname,libVisionCamera.so -o ../../../../build/intermediates/cxx/Debug/93z355m5/obj/arm64-v8a/libVisionCamera.so CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCamera.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/JSIJNIConversion.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/FrameHostObject.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/CameraView.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/VisionCameraScheduler.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JFrameProcessorPlugin.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JImageProxy.cpp.o CMakeFiles/VisionCamera.dir/src/main/cpp/java-bindings/JHashMap.cpp.o  /Users/denisbevilacqua/.gradle/caches/transforms-3/6e906ae11a9e62f178ac1fed272cf94e/transformed/jetified-hermes-android-0.72.5-debug/prefab/modules/libhermes/libs/android.arm64-v8a/libhermes.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/18e790de7d60dccd07e3a88da530f5b8/transformed/jetified-react-android-0.72.5-debug/prefab/modules/folly_runtime/libs/android.arm64-v8a/libfolly_runtime.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/18e790de7d60dccd07e3a88da530f5b8/transformed/jetified-react-android-0.72.5-debug/prefab/modules/glog/libs/android.arm64-v8a/libglog.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/18e790de7d60dccd07e3a88da530f5b8/transformed/jetified-react-android-0.72.5-debug/prefab/modules/jsi/libs/android.arm64-v8a/libjsi.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/18e790de7d60dccd07e3a88da530f5b8/transformed/jetified-react-android-0.72.5-debug/prefab/modules/reactnativejni/libs/android.arm64-v8a/libreactnativejni.so  /Users/denisbevilacqua/.gradle/caches/transforms-3/34c2120d0d3cd8dc97826fc02c9e8fc4/transformed/jetified-fbjni-0.3.0/prefab/modules/fbjni/libs/android.arm64-v8a/libfbjni.so  /Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/lib/aarch64-linux-android/26/liblog.so  -landroid   -latomic -lm && :
  ld: error: undefined symbol: reanimated::extractWorkletRuntime(facebook::jsi::Runtime&, facebook::jsi::Value const&)
  >>> referenced by FrameProcessorRuntimeManager.cpp:105 (/Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android/src/main/cpp/FrameProcessorRuntimeManager.cpp:105)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(vision::FrameProcessorRuntimeManager::setFrameProcessor(facebook::jsi::Runtime&, int, facebook::jsi::Value const&, facebook::jsi::Value const&))

  ld: error: undefined symbol: reanimated::extractShareableOrThrow(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&)
  >>> referenced by Shareables.h:163 (/Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-reanimated/android/build/prefab-headers/reanimated/Shareables.h:163)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::shared_ptr<reanimated::ShareableWorklet> reanimated::extractShareableOrThrow<reanimated::ShareableWorklet>(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&))

  ld: error: undefined symbol: typeinfo for reanimated::Shareable
  >>> referenced by memory:0 (/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/memory:0)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::enable_if<(!(is_array<reanimated::ShareableWorklet>::value)) && (!(is_array<reanimated::Shareable>::value)), std::__ndk1::shared_ptr<reanimated::ShareableWorklet> >::type std::__ndk1::dynamic_pointer_cast<reanimated::ShareableWorklet, reanimated::Shareable>(std::__ndk1::shared_ptr<reanimated::Shareable> const&))
  >>> referenced by memory:0 (/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/memory:0)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::enable_if<(!(is_array<reanimated::ShareableWorklet>::value)) && (!(is_array<reanimated::Shareable>::value)), std::__ndk1::shared_ptr<reanimated::ShareableWorklet> >::type std::__ndk1::dynamic_pointer_cast<reanimated::ShareableWorklet, reanimated::Shareable>(std::__ndk1::shared_ptr<reanimated::Shareable> const&))

  ld: error: undefined symbol: typeinfo for reanimated::ShareableWorklet
  >>> referenced by memory:0 (/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/memory:0)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::enable_if<(!(is_array<reanimated::ShareableWorklet>::value)) && (!(is_array<reanimated::Shareable>::value)), std::__ndk1::shared_ptr<reanimated::ShareableWorklet> >::type std::__ndk1::dynamic_pointer_cast<reanimated::ShareableWorklet, reanimated::Shareable>(std::__ndk1::shared_ptr<reanimated::Shareable> const&))
  >>> referenced by memory:0 (/Users/denisbevilacqua/Library/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/memory:0)
  >>>               CMakeFiles/VisionCamera.dir/src/main/cpp/FrameProcessorRuntimeManager.cpp.o:(std::__ndk1::enable_if<(!(is_array<reanimated::ShareableWorklet>::value)) && (!(is_array<reanimated::Shareable>::value)), std::__ndk1::shared_ptr<reanimated::ShareableWorklet> >::type std::__ndk1::dynamic_pointer_cast<reanimated::ShareableWorklet, reanimated::Shareable>(std::__ndk1::shared_ptr<reanimated::Shareable> const&))
  clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
  ninja: build stopped: subcommand failed.

  C++ build system [build] failed while executing:
      /Users/denisbevilacqua/Library/Android/Sdk/cmake/3.22.1/bin/ninja \
        -C \
        /Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android/.cxx/Debug/93z355m5/arm64-v8a \
        VisionCamera
    from /Users/denisbevilacqua/Desktop/nationsbenefits/nb-flexpay-mobile/node_modules/react-native-vision-camera/android

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1m 57s

@tomekzaw This issue was resolved for me by deleting the .gradle folder from <NameOfProject>/android and then running it again with yarn android. Do you know or have any idea why this happens?

* Update Podfile.lock * Install REA v3 * Upgrade project to RN 0.71 * Update build.gradle * Update packages * Add VisionCamera pod again * Update dev deps * Extend TSConfig from RN * Fix Linting setup * fix tsconfig * Update project.pbxproj * Update Info.plist * Use `JSRuntimeHelper` (temporary workaround) * Wrap in GestureHandlerRootView * Use new console.log * fix: Update CameraRoll * It works! * Print _WORKLET in frameProcessor * Enforce shareable type * It works again! * console.log works * Setup console in Reanimated * Adapt to WorkletRuntime * Update Podfile.lock * Update CameraPage.tsx * Android works! * Fix iOS * Remove paths to Reanimated headers from node_modules from `target_include_directories` in CMakeLists.txt * Bump `com.android.tools.build:gradle` from 7.3.1 to 7.4.2 fix issue Gradle Sync issue * Use `@tomekzaw/prefab` branch instead of `link:` * Remove unnecessary header * Consume Reanimated from commit * Remove dependency on Reanimated Scheduler on iOS * Go back * Remove dependency on Reanimated Scheduler on Android * Pass job as runnable * Remove `makeJSIRuntime` * Use nightly * Remove react-native-reanimated from `watchFolders` in metro.config.js * Fix crash on reload * Fix import * Barcode detection works * Use latest commit * Use `runGuarded` instead of `callWithThis` * Remove private field * Remove unused type * fix: Optionally require Reanimated * Update .gitignore * chore: Revert example app changes * chore: Remove unused packages from example app --------- Co-authored-by: Marc Rousavy <me@mrousavy.com> Co-authored-by: Marc Rousavy <marcrousavy@hotmail.com>

mrousavy and others added 30 commits June 14, 2023 17:09

Update Podfile.lock

3d5dc03

Install REA v3

87fa369

Upgrade project to RN 0.71

61d2be6

Update build.gradle

0f82985

Update packages

d791ee3

Add VisionCamera pod again

a2e0e1d

Update dev deps

efb91f8

Extend TSConfig from RN

a5f4711

Fix Linting setup

b3cfca9

fix tsconfig

1f93ccc

Update project.pbxproj

b254017

Update Info.plist

7e93460

Use JSRuntimeHelper (temporary workaround)

6681be2

Wrap in GestureHandlerRootView

f336643

Use new console.log

79e7692

fix: Update CameraRoll

294301a

It works!

be7a5ef

Print _WORKLET in frameProcessor

d85e02a

Enforce shareable type

df20ac2

It works again!

fc5a63d

console.log works

73055bb

Setup console in Reanimated

91d2aa8

Adapt to WorkletRuntime

4b2ff25

Merge branch 'mrousavy:main' into @tomekzaw/rea-v3

6d043ef

Update Podfile.lock

673d73b

Update CameraPage.tsx

afdaa54

Android works!

3a4140f

Fix iOS

56a9716

Remove paths to Reanimated headers from node_modules from `target_inc…

e174560

…lude_directories` in CMakeLists.txt

Bump com.android.tools.build:gradle from 7.3.1 to 7.4.2 fix issue G…

a39dbd3

…radle Sync issue

mrousavy and others added 2 commits September 7, 2023 12:12

fix: Optionally require Reanimated

401ea32

Update .gitignore

366872b

vercel bot deployed to Preview September 7, 2023 10:16 View deployment

chore: Revert example app changes

a7a4af1

vercel bot deployed to Preview September 7, 2023 10:17 View deployment

chore: Remove unused packages from example app

e323a61

vercel bot deployed to Preview September 7, 2023 10:18 View deployment

tomekzaw mentioned this pull request Sep 13, 2023

iOS: Version 2.17.0 fails to build on React Native 0.72.0+ software-mansion/react-native-reanimated#4522

Closed

xulihang mentioned this pull request Sep 18, 2023

How can i implement QR code Scanner with vision camera❓ #1807

Closed

4 tasks

mrousavy merged commit fe947bb into mrousavy:v2 Sep 18, 2023
4 of 11 checks passed

tomekzaw deleted the @tomekzaw/rea-v3 branch September 19, 2023 02:09

tomekzaw mentioned this pull request Sep 19, 2023

fix: restore support for v2 without frame processors #1812

Merged

xulihang mentioned this pull request Nov 20, 2023

🐛 Frame processor + take photo causes crashes #2141

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Reanimated v3 support in RNVisionCamera v2 #1759

feat: Reanimated v3 support in RNVisionCamera v2 #1759

tomekzaw commented Sep 4, 2023 •

edited

Loading

mrousavy commented Sep 6, 2023

mrousavy commented Sep 18, 2023

stevepepple commented Sep 18, 2023

efstathiosntonas commented Sep 18, 2023 •

edited

Loading

short-dsb commented Sep 18, 2023

tomekzaw commented Sep 19, 2023

efstathiosntonas commented Sep 19, 2023 •

edited

Loading

efstathiosntonas commented Sep 19, 2023 •

edited

Loading

mrousavy commented Sep 19, 2023

vadbertalan commented Oct 2, 2023

tomekzaw commented Oct 2, 2023

vadbertalan commented Oct 2, 2023

denisbevilacqua commented Oct 3, 2023 •

edited

Loading

tomekzaw commented Oct 3, 2023

denisbevilacqua commented Oct 3, 2023

denisbevilacqua commented Oct 4, 2023

feat: Reanimated v3 support in RNVisionCamera v2 #1759

feat: Reanimated v3 support in RNVisionCamera v2 #1759

Conversation

tomekzaw commented Sep 4, 2023 • edited Loading

What

Changes

Demo

Tested on

Related issues

mrousavy commented Sep 6, 2023

mrousavy commented Sep 18, 2023

stevepepple commented Sep 18, 2023

efstathiosntonas commented Sep 18, 2023 • edited Loading

short-dsb commented Sep 18, 2023

tomekzaw commented Sep 19, 2023

efstathiosntonas commented Sep 19, 2023 • edited Loading

efstathiosntonas commented Sep 19, 2023 • edited Loading

mrousavy commented Sep 19, 2023

vadbertalan commented Oct 2, 2023

tomekzaw commented Oct 2, 2023

vadbertalan commented Oct 2, 2023

denisbevilacqua commented Oct 3, 2023 • edited Loading

tomekzaw commented Oct 3, 2023

denisbevilacqua commented Oct 3, 2023

denisbevilacqua commented Oct 4, 2023

tomekzaw commented Sep 4, 2023 •

edited

Loading

efstathiosntonas commented Sep 18, 2023 •

edited

Loading

efstathiosntonas commented Sep 19, 2023 •

edited

Loading

efstathiosntonas commented Sep 19, 2023 •

edited

Loading

denisbevilacqua commented Oct 3, 2023 •

edited

Loading