Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Silent and Vibrate mode, shutter sound is mute #2433

Closed

Conversation

quannq-vvt
Copy link

@quannq-vvt quannq-vvt commented Jan 25, 2024

What

when this PR appears: #1702 then android when taking a snap with silent mode and vibrate mode always has sound, this makes the app like an error on Android

Tested on

Zflip 5
Samsung a54

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 8:56am

@mrousavy
Copy link
Owner

Hey - thanks for this PR mate, what happens without your change though? Does the app crash? What error is being thrown?

@quannq-vvt
Copy link
Author

Hey - thanks for this PR mate, what happens without your change though? Does the app crash? What error is being thrown?

It does not crash or throw an error, it's normal except if the user uses Android with silent or vibrate mode, it always has a shutter sound. It's so uncomfortable if your phone is silent but still makes a sound

@mrousavy
Copy link
Owner

mrousavy commented Feb 2, 2024

Ah, I see! Okay well this is more of a "how do we want it to behave question"...

@quannq-vvt
Copy link
Author

if you find it reasonable, hope you update soon! Thanks for your job

@omerts
Copy link

omerts commented Apr 9, 2024

Hi, would like to see this merged as well please. We got a complient about this, since if the phone is in silent mode camera should not make sounds (especially since it makes the shutter sound by default).

@mrousavy
Copy link
Owner

mrousavy commented Apr 9, 2024

I just fixed this in V4 and released it in the latest beta. Thanks @quannq-vvt, I took your approach and adjusted it a bit, but the idea is the same!

@quannq-vvt quannq-vvt closed this Apr 10, 2024
@quannq-vvt quannq-vvt reopened this Apr 10, 2024
@quannq-vvt
Copy link
Author

done

@quannq-vvt quannq-vvt closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants