Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle both scope and resource permission types #220

Merged
merged 6 commits into from
Feb 25, 2020

Conversation

yspotts
Copy link
Contributor

@yspotts yspotts commented Feb 12, 2020

This PR allows for handling all types of permissions - resources as well as scopes

Copy link
Owner

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Would you be able to update one of the existing test cases for this resource to include the new scopes attribute?

@chopshop1
Copy link
Contributor

@mrparkers
Hey, we updated some tests, and the example. Could you please let us know what you think?

@rfahsel3
Copy link

rfahsel3 commented Feb 21, 2020

@mrparkers Wow! This would be really helpful. Can we get this merged? It looks like the tests have been completed.

@mrparkers
Copy link
Owner

Thanks for adding the tests, @Amad27!

I pulled this down locally and tested the changes you made to example/main.tf. Everything looks good, except that running terraform apply and then running a following terraform destroy results in a failure. This appears to only happen on this branch and not on master. Would you or @yspotts mind taking a look at this?

@chopshop1
Copy link
Contributor

@mrparkers I just retested it locally and was able to get it to apply and destroy without errors after running the make user-federation-example command. Could you please show me what error are you receiving?

@mrparkers
Copy link
Owner

Hmm, I must have had something weird going on with my local setup, because I'm not running into those errors anymore.

I probably just messed something up locally.

@mrparkers mrparkers merged commit 3ac4399 into mrparkers:master Feb 25, 2020
chopshop1 pushed a commit to ware2go/terraform-provider-keycloak that referenced this pull request Mar 3, 2020
chopshop1 pushed a commit to ware2go/terraform-provider-keycloak that referenced this pull request Mar 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants