Add LifeCycle to FluxorOptions and use in registration #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cle value when registering fluxor components
|
addresses #280 |
mrpmorris
requested changes
Apr 7, 2022
Source/Fluxor/DependencyInjection/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Source/Fluxor/DependencyInjection/ServiceRegistration/EffectClassRegistration.cs
Show resolved
Hide resolved
* AddRegistration renamed to Add * consolidated Add extension methods into IServiceCollectionExtensions.cs * rename RegistrationLifecycle to StoreLifetime and made a public property * currently left the SetStoreLifetime method in Options -- awaiting feedback in PR discussion * rename LifecycleEnum to StoreLifetime * improve XmlDoc comments for StoreLifetime
* renamed SetStoreLifetime() to WithServiceLifetime() * change StoreLifetime prop to internal
mrpmorris
requested changes
Apr 11, 2022
renamed WithServiceLifetime() to WithLifetime()
|
Merged. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.