Skip to content

Commit

Permalink
CDI event observer methods cannot be generic due to type erasure
Browse files Browse the repository at this point in the history
  • Loading branch information
mrts committed Jan 19, 2024
1 parent b38d605 commit c11dd61
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
9 changes: 1 addition & 8 deletions src/main/java/org/test/AbstractBroadcaster.java
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
import javax.annotation.Resource;
import javax.enterprise.concurrent.ManagedExecutorService;
import javax.enterprise.event.Event;
import javax.enterprise.event.Observes;
import javax.enterprise.event.ObservesAsync;
import javax.enterprise.event.TransactionPhase;
import javax.inject.Inject;
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.function.Consumer;
Expand Down Expand Up @@ -45,11 +42,7 @@ public void broadcastAsync(M message) {
messageEvent.fireAsync(message);
}

private void onMessageAsync(@ObservesAsync M message) {
onMessage(message);
}

private void onMessage(@Observes(during = TransactionPhase.AFTER_SUCCESS) M message) {
protected void onMessageImpl(M message) {
log.info("{} got message {}, listeners are: {}", this, message, listeners);
for (final Consumer<M> listener : listeners) {
executorService.execute(() -> {
Expand Down
13 changes: 13 additions & 0 deletions src/main/java/org/test/Broadcaster.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,20 @@
package org.test;

import javax.enterprise.context.ApplicationScoped;
import javax.enterprise.event.Observes;
import javax.enterprise.event.ObservesAsync;
import javax.enterprise.event.TransactionPhase;

@ApplicationScoped
public class Broadcaster extends AbstractBroadcaster<Message> {

// CDI event observer methods cannot be generic due to type erasure.
private void onMessageAsync(@ObservesAsync Message message) {
onMessageImpl(message);
}

private void onMessage(@Observes(during = TransactionPhase.AFTER_SUCCESS) Message message) {
onMessageImpl(message);
}

}

0 comments on commit c11dd61

Please sign in to comment.