Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for C89-style variable declarations #1727

Merged
merged 1 commit into from
Feb 23, 2014
Merged

Conversation

bggd
Copy link
Contributor

@bggd bggd commented Feb 23, 2014

No description provided.

@bovi
Copy link
Member

bovi commented Feb 23, 2014

It seems this doesn't compile numerics:

mruby/src/numeric.c: In function ‘mrb_flo_to_str’:
mruby/mruby/src/numeric.c:148:5: error: ISO C90 forbids mixed declarations and code 

@tsahara
Copy link
Member

tsahara commented Feb 23, 2014

mruby's coding style recommends C99 currently: https://github.com/mruby/mruby/blob/master/CONTRIBUTING.md#comply-with-c99-isoiec-98991999 .

@bggd
Copy link
Contributor Author

bggd commented Feb 23, 2014

Sorry for my poor english.
commit title is probably wrong.
"Add warning for C99 style variable declarations" is wright.

matz added a commit that referenced this pull request Feb 23, 2014
matz added a commit that referenced this pull request Feb 23, 2014
Add warning for C89-style variable declarations
@matz matz merged commit 109f675 into mruby:master Feb 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants