make mrb_time_local() use the same types as other methods in time.c #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mrb_time_gm() uses mrb_int * Same for mrb_time_initialize() * The parameters to time_mktime() are mrb_int, and that's what these values are passed to So I don't see why mrb_time_local() works on mrb_float instead. Lets make it consistent with the other methods defined in time.c
| @@ -281,10 +281,10 @@ struct mrb_time* | |||
| static mrb_value | |||
| mrb_time_local(mrb_state *mrb, mrb_value self) | |||
| { | |||
| mrb_float ayear = 0.0, amonth = 1.0, aday = 1.0, ahour = 0.0, | |||
| mrb_int ayear = 0.0, amonth = 1.0, aday = 1.0, ahour = 0.0, | |||
There was a problem hiding this comment.
should be integer constants?
|
good point, I'll fix that |
As per monaka's comment here... mruby#175 ...changing these initializations of mrb_int values to use integer constants
|
fixed in 826386a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I don't see why mrb_time_local() works on mrb_float instead. Lets make
it consistent with the other methods defined in time.c