New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper error handling for instance_eval and friends #2486

Closed

IceDragon200 wants to merge 1 commit into mruby:master from IceDragon200:eval-error-handling

Contributor

IceDragon200 commented Jul 22, 2014

Any of the following method calls will result in a segfault when no parameters or block is given:

instance_eval
module_eval
class_eval

I've patched the methods in question by adding a simple nil check and raising an error if true.


          raise error when class_eval, module_eval, or instance_eval is called …

5e9dec3

…without parameters

Member

matz commented Jul 22, 2014

I prefer checking in eval_under to keep DRY.

matz closed this in

1b5584b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet