WIP: make sensors web configurable #54
Conversation
|
Thank you! This would be a great addition to the project. I'll look forward to your feedback. I found one thing, that is likeley to make troubles and I'll comment it within the code. |
src/MqttPublisher.h
Outdated
| { | ||
| const char* willTopic = lastWillTopic.c_str(); | ||
| const char* buf = new_json_wrap(willTopic, MQTT_LWT_PAYLOAD_OFFLINE); | ||
| client.setWill(willTopic, MQTT_LWT_QOS, MQTT_LWT_RETAIN, buf); |
There was a problem hiding this comment.
While working on the latest changes (including the replacement of the MQTT library), I noticed that the MQTT client won't reconnect, if the pointer to the last will topic has become invalid. That's why I stored the last will topic in a previously defined variable in the scope of the class. I think we should do it this way for the JSON wrapped topic, too.
|
thanks for the review! I added a couple of lines to use the stored |
|
The sensor now ran with the merged changes for the last couple of days. MQTT survived router reboots and internet connection losses in between. I would greatly appreciate if this could be merged. |
|
I am sure that I will merge the PR. But before that I would like to test it myself and we still need to update the manual because the configuration is not preserved during the update and the configuration via web interface still needs to be explained in the readme. Since I have very little time right now, I don't know when I will get to it. |
|
I haven't forgotten the PR, I'm just busy with my bachelor thesis at the moment and won't have time to work on SMLReader again until March. |
|
Good luck with the thesis |
Thank you for the awesome work! I had the issue that I did not want to recompile the firmware when installing an ESP. To solve that I moved configuring sensors to the web interface. I also added an option to publish JSON formatted MQTT payloads which is required by thingsboard and added a small
/statuspage. I would appreciate if you accept this pull request.Note: The changes ran quite smoothly for several weeks. I just made final adoptions to merge your latest changes from v3.0.0 and updated my ESP. The last hour seemed good. I will give feedback in a couple of days if everything is still running as expected.