Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor database naming strategy #42

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

mruoss
Copy link
Owner

@mruoss mruoss commented Jul 30, 2023

Make strategy an enum field with resource_name and prefix_namespace as possible values and prefix_namespace as default strategy.

  • Updated docs
  • added changelog
  • updated CRD in helm chart

@sleipnir What do you think? It gives us the flexibility to introduce further strategies if needed.

refs #38

@mruoss mruoss force-pushed the refactor-db-naming-strategy branch 3 times, most recently from 539da79 to 9e7b55a Compare July 30, 2023 19:23
@mruoss mruoss force-pushed the refactor-db-naming-strategy branch from 9e7b55a to 1274c5a Compare July 30, 2023 19:35
@sleipnir
Copy link
Contributor

sleipnir commented Jul 30, 2023

Make strategy an enum field with resource_name and prefix_namespace as possible values and prefix_namespace as default strategy.

* Updated docs

* added changelog

* updated CRD in helm chart

@sleipnir What do you think? It gives us the flexibility to introduce further strategies if needed.

refs #38

Ok @mruoss as you prefer if you think there might be other strategies in the future. I just don't like using such a long word like resource_name. I think you could switch just to named.
Do you have any idea when a version with this would be available?

@mruoss mruoss merged commit dfc8e4e into main Jul 31, 2023
13 checks passed
@mruoss mruoss deleted the refactor-db-naming-strategy branch July 31, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants