-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat. Add database naming strategy #38
Conversation
Thanks @sleipnir |
Hey @sleipnir
using_prefix_strategy? = resource["spec"]["usingPrefixNamingStrategy"] != "false"
db_name = Database.name(resource, prefix_namespace: using_prefix_strategy?) Note I've changed the second argument of I can take it from here if you want. |
Perfect for me. I prefer to use pattern matching than chained map calls but ok. |
Hi @mruoss I believe that now everything is ok. Can you review it again please? |
Thanks @sleipnir, I'll merge this. I will add a changelog entry and I might change the field from boolean to string before releasing it (i.e. BTW: I'm prefixing the namespace per default so there's no conflicts if we have db resources with the same name in different namespaces. But if the user overrides this manually, that's okay I guess. |
Includes the possibility of not forcing the use of the namespace in the name composition.