Remove prerelease attribute from nuget version #31
Conversation
The clock divider for the i2c controller on RPI2 was not adjusted to the RPI2 clock speed. So, fixes it for both high and normal speed. Additionally, there are miscellaneous code cleanup for various sources.
|
👍 |
| @@ -265,8 +265,8 @@ class BcmI2cControllerClass : public I2cControllerClass | |||
| const ULONG _DIV_USED_MASK = 0x0000FFFF; // Mask of non-reserved bits in the Clock Divider Register | |||
|
|
|||
| // Standard (100khz) and high (400khz) divider values. | |||
| const ULONG CDIV_100KHZ = 1500; | |||
| const ULONG CDIV_400KHZ = 376; // Actually 398.9khz, divider value must be even | |||
| const ULONG CDIV_100KHZ = 2500; | |||
There was a problem hiding this comment.
If the original value worked (for something, I assume), would there be a selector to get the appropriate values for that device? If not, how did we test it before (or did it never work? needs a test).
There was a problem hiding this comment.
We definitely need a unit test here - should be part of the overall test plan.
It was tested before increasing the RPI2 clock speed. However, with the clock speed upgrade, both normal and high i2c bus speeds became wrong (too high).
There was a problem hiding this comment.
I suspect this change is for the clock speedup on PI2--the old value worked with the slower clock.
Are we removing 400khz I2C clock support for PI?
There was a problem hiding this comment.
Yes, this is needed for the speedup.
No, we're not removing the 400KHz support. It's updated (below) as well to account for the new clock speed.
|
except for my comment (either 1. a selector per device, or 2. it never worked (needs unit test)), it looks good. |
Remove prerelease attribute from nuget version
No description provided.