Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct task provider usages #127

Merged
merged 3 commits into from Sep 18, 2019
Merged

Conversation

seanyen
Copy link

@seanyen seanyen commented Sep 17, 2019

  • Defined all the task types in package.json.
  • Dropped the extra (and reserved) $ prefix from the name of problem matcher. Otherwise, the vscode will be complaining unexpected object types when it is referred in tasks.json.
  • Removed the unused target attribute to avoid VSCode throwing out errors about Property target is not allowed when adding tasks in tasks.json.
  • Register all task providers by correct types.

fix #126, #114

@seanyen seanyen requested a review from a team September 17, 2019 22:29
@seanyen seanyen merged commit 1db7f49 into ms-iot:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] The task [catkin_make, build] uses an undefined task type
2 participants