Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for error: #241

Merged
merged 2 commits into from
Jun 26, 2020
Merged

bugfix for error: #241

merged 2 commits into from
Jun 26, 2020

Conversation

humanoid2050
Copy link

The task provider for "catkin_cmake" tasks unexpectedly provided a task of type "catkin_make".

@humanoid2050 humanoid2050 requested a review from a team as a code owner June 22, 2020 00:34
@ooeygui
Copy link
Member

ooeygui commented Jun 22, 2020

Thank you for your contribution. I'm not clear on where this error manifests - can you explain further?
I also see that you changed the python path in the settings.json - could you revert that file?

@humanoid2050
Copy link
Author

Sorry about the delay. I am using VSCode on Ubuntu 20.04

Version: 1.46.1
Commit: cd9ea6488829f560dc949a8b2fb789f3cdc05f5d
Date: 2020-06-17T21:13:08.304Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.4.0-37-generic snap

I am using ROS noetic. I have a ROS workspace that I'm bringing forward from ROS Lunar.

When I enable this plugin and set the default default build command (generate tasks.json with a entry of "type": "catkin_make"), the following output is generated in the Output panel of VSCode

The task provider for "catkin_cmake" tasks unexpectedly provided a task of type "catkin_make".
The task provider for "catkin_cmake_isolated" tasks unexpectedly provided a task of type "catkin_make_isolated".

whenever I try to actually invoke the build command using the shortcut Ctrl+Shift+B. The build command does not execute.

There was a similar issue in a different plugin a while back: https://github.com/microsoft/vscode-cpptools/issues/5388

In all fairness, I'm new to VSCode and this plugin, so this may not be the correct solution, but this change did solve the problem and now the build task works properly.

humanoid2050 added 2 commits June 26, 2020 10:28
The task provider for "catkin_cmake" tasks unexpectedly provided a task of type "catkin_make".
@seanyen
Copy link

seanyen commented Jun 26, 2020

LGTM. Thanks for your contribution!

@seanyen seanyen merged commit c218c4b into ms-iot:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants