Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle preLaunch task explicitly #304

Merged
merged 13 commits into from
Sep 23, 2020

Conversation

anton-matosov
Copy link

@anton-matosov anton-matosov commented Sep 20, 2020

Fixes #166
Fixes #129

Switch to resolveDebugConfigurationWithSubstitutedVariables in the DebugConfigurationProvider which provides automatic handling of the preLaunch task (#166) as well as variables expansion in launch config (#129).

Stop returning config from the resolvers. This fixes allows to not even start debug adapter, which we terminate right away anyways. Moreover, it fixes fairly often race condition in vscode.debugger that results in re-sending same request 5-6 times. This is most likely caused by the new debugger requests spawning from the debugger request handler.

Implement await for the extension.env in launch and attach requests for the case if reload have been triggered in the midst of the request processing. That happens in 100% of cases if preLaunch task runs catkin make/build

@anton-matosov anton-matosov requested a review from a team as a code owner September 20, 2020 04:12
@ghost
Copy link

ghost commented Sep 20, 2020

CLA assistant check
All CLA requirements met.

@anton-matosov
Copy link
Author

While fixing #129 I have found that switching to resolveDebugConfigurationWithSubstitutedVariables handles preLaunchTask correctly and gives variables resolution. So I have revetred explicit handling of the preLaunchTask and only left changes for handling env reload and suppression of the debug adapter startup

@ooeygui
Copy link
Member

ooeygui commented Sep 21, 2020

Wow! Thank you for the contribution!
I looked through the change, and it looks good. I'll pull it down and run through some testing on Monday and pull it in.
@seanyen when you get a moment, can you review as well?

@seanyen
Copy link

seanyen commented Sep 23, 2020

Thanks for your contribution!

@seanyen seanyen merged commit c4df5d0 into ms-iot:master Sep 23, 2020
@anton-matosov anton-matosov deleted the handle-preLaunchTask-properly branch September 28, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants