Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preorder to post-order #109

Merged
merged 58 commits into from
Feb 15, 2022
Merged

Use preorder to post-order #109

merged 58 commits into from
Feb 15, 2022

Conversation

ms609
Copy link
Owner

@ms609 ms609 commented Feb 11, 2022

Will mean removing sizeSort and renumber parameters

Check reverse dependencies:

  • TreeSearch
  • TreeDist
  • Rogue
  • Quartet

Will complete #49

@ms609 ms609 mentioned this pull request Feb 11, 2022
6 tasks
Repository owner deleted a comment from codecov bot Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #109 (8ac20ca) into master (1c9072b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8ac20ca differs from pull request most recent head 857b70e. Consider uploading reports for the commit 857b70e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   97.04%   97.05%   +0.01%     
==========================================
  Files          45       45              
  Lines        3751     3703      -48     
==========================================
- Hits         3640     3594      -46     
+ Misses        111      109       -2     
Impacted Files Coverage Δ
src/TreeTools-init.c 100.00% <ø> (ø)
R/RcppExports-manual.R 60.00% <100.00%> (ø)
R/Splits.R 98.71% <100.00%> (+0.05%) ⬆️
R/TreeNumber.R 99.27% <100.00%> (ø)
R/phylo.R 99.39% <100.00%> (ø)
R/tree_display.R 100.00% <100.00%> (ø)
R/tree_generation.R 100.00% <100.00%> (ø)
R/tree_numbering.R 100.00% <100.00%> (ø)
R/tree_rearrangement.R 98.22% <100.00%> (+<0.01%) ⬆️
R/tree_shape.R 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff113e...857b70e. Read the comment docs.

@ms609 ms609 mentioned this pull request Feb 14, 2022
@ms609 ms609 merged commit a87f4d3 into master Feb 15, 2022
@ms609 ms609 deleted the postorder-from-pre branch February 15, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant