Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better URL handling #1206

Merged
merged 2 commits into from Jan 11, 2019
Merged

Better URL handling #1206

merged 2 commits into from Jan 11, 2019

Conversation

GlazerMann
Copy link
Collaborator

Add a bunch more types of URLs to look at.

More importantly, if there is both a url and a chapter-url, then we prefer the chapter one, and we do not delete either one of them when we are done.

@GlazerMann GlazerMann requested a review from ms609 January 11, 2019 00:36
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3b36d26). Click here to learn what that means.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1206   +/-   ##
=========================================
  Coverage          ?   79.23%           
  Complexity        ?     1847           
=========================================
  Files             ?       11           
  Lines             ?     3815           
  Branches          ?        0           
=========================================
  Hits              ?     3023           
  Misses            ?      792           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Template.php 80.63% <36.36%> (ø) 1738 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b36d26...0ef6b31. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3b36d26). Click here to learn what that means.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1206   +/-   ##
=========================================
  Coverage          ?   79.13%           
  Complexity        ?     1847           
=========================================
  Files             ?       11           
  Lines             ?     3819           
  Branches          ?        0           
=========================================
  Hits              ?     3022           
  Misses            ?      797           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Template.php 80.5% <30.76%> (ø) 1738 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b36d26...05ab4d9. Read the comment docs.

@GlazerMann GlazerMann merged commit 42426f8 into master Jan 11, 2019
@GlazerMann GlazerMann deleted the GlazerMann-patch-10 branch January 11, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants