Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not search book bibcodes #736

Merged
merged 13 commits into from
Sep 18, 2018
Merged

Do not search book bibcodes #736

merged 13 commits into from
Sep 18, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Sep 7, 2018

Need to learn to parse this data before we use it.
http://adsabs.harvard.edu/abs/2003hoe..book.....K
Add bogus journal data, etc.

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #736 into master will decrease coverage by 0.87%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #736      +/-   ##
============================================
- Coverage      69.3%   68.42%   -0.88%     
- Complexity     1621     1637      +16     
============================================
  Files            12       12              
  Lines          3264     3319      +55     
============================================
+ Hits           2262     2271       +9     
- Misses         1002     1048      +46
Impacted Files Coverage Δ Complexity Δ
apiFunctions.php 69.27% <0%> (+1.76%) 0 <0> (ø) ⬇️
Template.php 73.9% <100%> (-2.19%) 1457 <0> (+7)
Comment.php 100% <0%> (ø) 12% <0%> (+8%) ⬆️
expandFns.php 90.71% <0%> (+0.71%) 0% <0%> (ø) ⬇️
Page.php 74.64% <0%> (+1.28%) 71% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee53e0e...c00a4f0. Read the comment docs.

ms609
ms609 previously requested changes Sep 7, 2018
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that'll hit each code instance please?
Adding a book bibcode to the existing test with multiple bibcodes should hit the apiFunctions instance.

@ms609 ms609 merged commit 629911e into ms609:master Sep 18, 2018
@GlazerMann GlazerMann deleted the patch-16 branch September 18, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants