Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zenodo is blocked #771

Merged
merged 6 commits into from
Dec 29, 2018
Merged

zenodo is blocked #771

merged 6 commits into from
Dec 29, 2018

Conversation

josve05a
Copy link
Contributor

This is both the wrong parameter ("type" would be a better one) and is not recomended by wither template or MoS style-guideline.
https://en.wikipedia.org/wiki/User_talk:Citation_bot#Misuse_of_Format

This is both the wrong parameter ("type" would be a better one) and is not recomended by wither template or MoS style-guideline.
https://en.wikipedia.org/wiki/User_talk:Citation_bot#Misuse_of_Format
@josve05a josve05a changed the title Update Template.php Do not add Accepted/submitted manuscript in |format= Sep 13, 2018
ms609
ms609 previously requested changes Sep 14, 2018
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edit. Before we accept, I'd like to suggest that the appropriate parameter for this information should be identified (is there a consensus that it is type?) and populated, so the bot doesn't miss an opportunity to mark links as less-than-perfect.

@josve05a
Copy link
Contributor Author

type: Provides additional information about the media type of the source; format in sentence case. Displays in parentheses following the title. Examples: Thesis, Booklet, CD liner, Press release. Alias: medium.

format: Format of the work referred to by url; for example: PDF, DOC, or XLS; displayed in parentheses after title. (For media format, use type.) HTML is implied and should not be specified. Automatically added when a PDF icon is displayed. Does not change the external link icon. Note: External link icons do not include alt text; thus, they do not add format information for the visually impaired.

I'm not sure if type is the correct parameter either (given the description of the parameter from the /doc page, that's why I simply commented out these rows of code until we've established if the bot should even be adding this to citation templates.

@ms609
Copy link
Owner

ms609 commented Sep 14, 2018

I've been [[WP:BOLD]] and edited the type documentation so that it is less ambiguous. Let's proceed on the basis that that parameter is the most suitable for this sort of information.

Copy link
Contributor Author

@josve05a josve05a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to type

@josve05a
Copy link
Contributor Author

...yeah...no. I can't code for sh*t. I just wanted to help out and get this taken care of the best I could. Seems my abilities are way too limited.

@josve05a josve05a closed this Sep 14, 2018
@GlazerMann
Copy link
Collaborator

I submitted a different pull request that cleans up old ones

@GlazerMann GlazerMann deleted the patch-1 branch September 14, 2018 23:23
@GlazerMann GlazerMann restored the patch-1 branch December 29, 2018 03:05
@GlazerMann GlazerMann reopened this Dec 29, 2018
@GlazerMann GlazerMann changed the title Do not add Accepted/submitted manuscript in |format= zenodo is Dec 29, 2018
@GlazerMann GlazerMann changed the title zenodo is zenodo isB Dec 29, 2018
@GlazerMann GlazerMann changed the title zenodo isB zenodo is blocked Dec 29, 2018
Repository owner deleted a comment from codecov bot Dec 29, 2018
Repository owner deleted a comment from codecov bot Dec 29, 2018
@GlazerMann GlazerMann dismissed ms609’s stale review December 29, 2018 03:11

Not relevant anymore

@GlazerMann
Copy link
Collaborator

Hijacking existing pull to get emergency work done

@GlazerMann GlazerMann self-requested a review December 29, 2018 03:33
@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #771 into master will decrease coverage by 2.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #771      +/-   ##
===========================================
- Coverage     79.97%   77.6%   -2.38%     
+ Complexity     1759    1758       -1     
===========================================
  Files            10      10              
  Lines          3636    3634       -2     
===========================================
- Hits           2908    2820      -88     
- Misses          728     814      +86
Impacted Files Coverage Δ Complexity Δ
Template.php 76.78% <ø> (-3.68%) 1651 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d3f04...ce8cda6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #771 into master will decrease coverage by 2.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #771      +/-   ##
===========================================
- Coverage     79.97%   77.6%   -2.38%     
+ Complexity     1759    1758       -1     
===========================================
  Files            10      10              
  Lines          3636    3634       -2     
===========================================
- Hits           2908    2820      -88     
- Misses          728     814      +86
Impacted Files Coverage Δ Complexity Δ
Template.php 76.78% <ø> (-3.68%) 1651 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d3f04...ce8cda6. Read the comment docs.

@GlazerMann GlazerMann merged commit d9753a5 into ms609:master Dec 29, 2018
@josve05a josve05a deleted the patch-1 branch December 29, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants