Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.8-alpha.0 #17

Merged
merged 4 commits into from
Jan 2, 2021
Merged

v0.5.8-alpha.0 #17

merged 4 commits into from
Jan 2, 2021

Conversation

ms7m
Copy link
Owner

@ms7m ms7m commented Jan 2, 2021

@todo
Copy link

todo bot commented Jan 2, 2021

Offer a setting to change the type for simply acknowledging a commmand

# TODO: Offer a setting to change the type for simply acknowledging a commmand
# per https://discord.com/developers/docs/interactions/slash-commands#interaction-response-interactionresponsetype
return {
"type": 2
}
elif _type_hinted_returned_value == dict:


This comment was generated by todo based on a TODO comment in a94ccff in #17. cc @ms7m.

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #17 (a94ccff) into master (747e0a0) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   83.36%   83.18%   -0.19%     
==========================================
  Files          13       13              
  Lines         457      458       +1     
==========================================
  Hits          381      381              
- Misses         76       77       +1     
Impacted Files Coverage Δ
dispike/server.py 85.45% <100.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747e0a0...a94ccff. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotReadyResponse must return a ACK response
1 participant