Fixes #6 canvas editing GUI didn't work for Igor and later #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6, SketchCanvas editor GUI stopped working since Igor, due to some changes in the way forms are handled.
Specifically, these changes were incompatible:
HTML_EDIT_FORMSELECTION
event is not invoked anymore.EDIT_FORM_ADDTEXTAREA
event uses a newForm
class instead ofDoku_Form
, which completely changes API.Previously, we injected a canvas and its accopanying small JavaScript code to synchronize the text area and the canvas. However it is no longer possible to directly inject text into the output HTML. We need a specific implementation of
Element
class.In order to keep backwards compatibility,
HTML_EDIT_FORMSELECTION
was left intact, and added a newEDIT_FORM_ADDTEXTAREA
handler with the customCanvasElement
class.Tested on: