move log file into log folder

msaltnet · Mar 26, 2023 · e74e910 · e74e910
1 parent ebd07bd
commit e74e910
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/smtm/log_manager.py b/smtm/log_manager.py
@@ -63,11 +63,9 @@ def set_stream_level(cls, level):
     @classmethod
     def change_log_file(cls, log_file="smtm.log"):
         """파일 핸들러의 로그 파일을 변경한다"""
-        if log_file == cls.LOG_FILE:
-            return
-
+        cls.LOG_FILE = f"{cls.LOG_FOLDER}/{log_file}"
         new_file_handler = RotatingFileHandler(
-            filename=log_file, maxBytes=cls.LOG_FILE_SIZE, backupCount=cls.BACKUP_COUNT
+            filename=cls.LOG_FILE, maxBytes=cls.LOG_FILE_SIZE, backupCount=cls.BACKUP_COUNT
         )
         new_file_handler.setLevel(logging.DEBUG)
         new_file_handler.setFormatter(cls.FORMATTER)
@@ -76,5 +74,4 @@ def change_log_file(cls, log_file="smtm.log"):
             logger.removeHandler(cls.HANDLER)
             logger.addHandler(new_file_handler)
 
-        cls.LOG_FILE = log_file
         cls.HANDLER = new_file_handler
diff --git a/tests/log_manager_test.py b/tests/log_manager_test.py
@@ -49,12 +49,3 @@ def test_change_log_file_should_change_file_handler(self):
                 self.assertNotEqual(old_handler, handler)
                 old_handler = handler
         self.assertTrue(has_RotatingFileHandler)
-
-        has_RotatingFileHandler = False
-        LogManager.change_log_file("kiwi.log")
-        for handler in logger.handlers:
-            if issubclass(type(handler), logging.handlers.RotatingFileHandler):
-                self.assertEqual(handler.baseFilename[-8:], "kiwi.log")
-                self.assertEqual(old_handler, handler)
-                has_RotatingFileHandler = True
-        self.assertTrue(has_RotatingFileHandler)