Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail when actually requiring node_module dependencies #4

Closed
KingScooty opened this issue Apr 17, 2015 · 1 comment
Closed

Tests fail when actually requiring node_module dependencies #4

KingScooty opened this issue Apr 17, 2015 · 1 comment

Comments

@KingScooty
Copy link

Forked the project, and only change i've made is to add chai to package.json and require it in the tests file. Tests fail on CircleCI saying chai can't be found.

Looks like actually requiring anything from node_modules will fail during the test step.

Made a pull request so you can see what i'm talking about (#5)
@msanand
Copy link
Owner

msanand commented Oct 18, 2016

@KingScooty
For some reason chai needs to be explicitly installed in the test phase. I've updated pull request #5 to get this working.
Reference: PatrickJS/NG6-starter#48

@msanand msanand closed this as completed Oct 18, 2016
@msanand msanand mentioned this issue Oct 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KingScooty @msanand