Skip to content

Commit

Permalink
Remove unused header macros
Browse files Browse the repository at this point in the history 
#23
  • Loading branch information
@msantos
msantos committed Jan 30, 2015
1 parent 5b1424a commit 41a9907
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions include/pkt_protocol_family.hrl
View file
Expand Up @@ -10,9 +10,3 @@
-ifndef(PF_INET).
-define(PF_INET, 2). % IP protocol family.
-endif.
-ifndef(PF_INET6).
-define(PF_INET6, 10). % IP version 6.
-endif.
-ifndef(PF_PACKET).
-define(PF_PACKET, 17). % Packet family.
-endif.

3 comments on commit 41a9907

@divolgin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These macros are used in gen_icmp. That repo no longer compiles.

If you could change rebar.config in gen_icmp to reference SHAs instead of branch names (right now it depends on master), this wouldn't happen.

@msantos
Copy link
Owner Author

@msantos msantos commented on 41a9907 Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. Thanks for the suggestion, I've pushed a fix to gen_icmp and hard coded the versions of pkt and procket to a tag. Lesson learned, hopefully that will prevent this sort of breakage in the future :)

@divolgin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for a quick turn around.

Please sign in to comment.