DataContract Compatibility is broken

[kikokikok]

Hi I am trying to use MsgPack on a client project, it contains types where DataMember decorates private properties and not fields. When MsgPack tries to serialize those it fails because it doesn't look for DataMembers on private properties.

Could you maybe help me find out the best way to add support for that in order to be fuly compatible with DataContract specs.

I'm working on the 0.5 beta 1 version / branch

Thank you
Brgrds,

[yfakariya]

@kikokikok

Sorry, it is a bug. I misunderstood DataContract behavior. I guess this fix rarely affect existing apps, so I will fix on 0.5 beta2.

[yfakariya]

I've fixed this issue and pushed now.

[kikokikok]

thanks for your reactivity, I'll test it and see how it goes.
just in order to be sure will it cover private decorated fields also ? because it is in the DataContractSerializer spec also

[kikokikok]

Hi,
It doesn't really fix the problem, now it is unable to deserialize the type with a private decorated field / property
pretty simple to reproduce with a Unit Test

[yfakariya]

Sorry. I had forgotten to test entire APIs, and I faced member accessibility related issues because serializers do not use reflection in runtime. (...And I faced another private iasue -- new baby was born.) I will tuckle this issue continuously, but it might take a long time to fix.

[yfakariya]

I fixed it, so it now supports following classes when the members are marked with [DataMember] or [MessagePackMember] attributes: https://github.com/msgpack/msgpack-cli/blob/0.5/test/MsgPack.UnitTest/Serialization/SerializationTargets.cs

[yfakariya]

Hi @kikokikok
Does this issue still exist?