Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpacker: Make default size limit smaller #319

Merged
merged 1 commit into from
Nov 8, 2018
Merged

unpacker: Make default size limit smaller #319

merged 1 commit into from
Nov 8, 2018

Conversation

methane
Copy link
Member

@methane methane commented Nov 8, 2018

To avoid DoS attack, make default size limit smaller.

Fixes #295

To avoid DoS attack, make default size limit smaller.

Fixes #295
@methane methane merged commit 3b80233 into msgpack:master Nov 8, 2018
@methane methane deleted the lower-default-limit branch November 8, 2018 13:21
Limits max length of map. (default: 32*1024)

:param int max_ext_len:
Limits max length of map. (default: 1024*1024)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it's incorrect description.


:param int max_ext_len:
Limits max length of map. (default: 1024*1024)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is too (incorrect description).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants