alcatel-idol3: Add headphones support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to see alcatel-idol347 first to be honest. :) |
|
Oh it's the same I guess. Nevermind :D |
stephan-gh
requested changes
Sep 20, 2021
vknecht
force-pushed
the
idol3-headphones
branch
from
83f36d3
to
9088592
Compare
stephan-gh
reviewed
Oct 8, 2021
vknecht
force-pushed
the
idol3-headphones
branch
from
45b3f00
to
67d9111
Compare
Add variable support for MultiMedia1, MultiMedia2 and MultiMedia4 ports. Keep default values for those respectively at: - PRI_MI2S_RX - TERT_MI2S_TX - PRI_MI2S_RX which is the usual usecase for most msm8916 phones.
idol3 and idol347 use SEC_MI2S_RX port instead of PRI_MI2S_RX. Also set MultiMedia4 to QUAT_MI2S_RX instead of PRI_MI2S_RX. Make use of related UCM variables to override default values.
Add support for VoiceRXPort and VoiceTXPort variables. Keep default values for those respectively at: - PRI_MI2S_RX - TERT_MI2S_TX which is the usual usecase for most msm8916 phones Those will be used as ALSA q6voice-dai controls.
Add support for setting q6voice-dai VoiceRXPort and VoiceTXPort controls Keep default values for those respectively at: - PRI_MI2S_RX - TERT_MI2S_TX which is the usual usecase for most msm8916 phones
idol3 and idol347 use SEC_MI2S_RX instead of PRI_MI2S_RX port. Set this value through VoiceRXPort variable.
Use generic pin switch mechanism instead of a tfa9897 specific control.
vknecht
force-pushed
the
idol3-headphones
branch
from
6d4ccde
to
8d49bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.