Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "-mincov" flag option (Issue #19) #20

Merged
merged 6 commits into from
Sep 8, 2022

Conversation

KEINOS
Copy link
Contributor

@KEINOS KEINOS commented Aug 29, 2022

@KEINOS
Copy link
Contributor Author

KEINOS commented Sep 2, 2022

@msoap

I think the PR passes the CI.
However, in Go 1.19, staticcheck analysis gives us an error that io/ioutil is deprecated. They want us to use io and os packages instead of ioutil.

$ golangci-lint run
go-carpet.go:7:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^
utils_test.go:4:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^

Do you want me to fix this in the PR as well?

@msoap
Copy link
Owner

msoap commented Sep 2, 2022

@KEINOS sorry for delay.

Do you want me to fix this in the PR as well?

better to fix it in separated pr, or i can fix it later

@KEINOS
Copy link
Contributor Author

KEINOS commented Sep 3, 2022

@msoap

better to fix it in separated pr

I agree. Let's have them in a separate PR!
Please run the workflow and review when you got time.

go-carpet.go Outdated Show resolved Hide resolved
@msoap
Copy link
Owner

msoap commented Sep 3, 2022

also i've fixed golangci-lint warnings in master, please merge master to your branch

@KEINOS KEINOS force-pushed the fix-issue19-show-only-uncovered branch from 8770d9e to 5e4a32a Compare September 6, 2022 02:18
@KEINOS
Copy link
Contributor Author

KEINOS commented Sep 6, 2022

also i've fixed golangci-lint warnings in master, please merge master to your branch

Rebased to the PR. How about now?

@KEINOS KEINOS requested a review from msoap September 6, 2022 03:26
Filtering in `getCoverForDir()` is enough.
@msoap msoap merged commit f7355b5 into msoap:master Sep 8, 2022
@msoap
Copy link
Owner

msoap commented Sep 8, 2022

@KEINOS thanks for contributing!

@KEINOS KEINOS deleted the fix-issue19-show-only-uncovered branch September 9, 2022 02:58
@KEINOS
Copy link
Contributor Author

KEINOS commented Dec 7, 2022

@msoap

Please release the changes when you got time.

The go install github.com/msoap/go-carpet@latest won't work as described in the README, the -mincov option.

@msoap
Copy link
Owner

msoap commented Dec 7, 2022

@KEINOS i've released - https://github.com/msoap/go-carpet/releases/tag/v1.10.0

@KEINOS
Copy link
Contributor Author

KEINOS commented Dec 8, 2022

@msoap Thank you! Now it works 👍 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants