HA 2024.1 - Multiple deprecated constants

[Troon]

From the logs on my 2024.1 install:

SOURCE_TYPE_GPS was used from jlrincontrol, this is a deprecated constant which will be removed in HA Core 2025.1. Use SourceType.GPS instead, please report it to the author of the 'jlrincontrol' custom integration
PRESSURE_BAR was used from jlrincontrol, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfPressure.BAR instead, please report it to the author of the 'jlrincontrol' custom integration

[ismarslomic]

Thanks for reporting this, @Troon! I will look at this in upcoming days and release new version of the integration

[ismarslomic]

Additional constants that are deprecated (seen in HA 2024.1.2)

1. PRESSURE_BAR was used from jlrincontrol, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfPressure.BAR instead, please report it to the author of the 'jlrincontrol' custom integration

2. PRESSURE_PSI was used from jlrincontrol, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfPressure.PSI instead, please report it to the author of the 'jlrincontrol' custom integration

3. LENGTH_KILOMETERS was used from jlrincontrol, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfLength.KILOMETERS instead, please report it to the author of the 'jlrincontrol' custom integration

4. LENGTH_METERS was used from jlrincontrol, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfLength.METERS instead, please report it to the author of the 'jlrincontrol' custom integration

5. PRESSURE_PA was used from jlrincontrol, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfPressure.PA instead, please report it to the author of the 'jlrincontrol' custom integration

[ismarslomic]

@msp1974 just a clarification regarding the homeassistant key in the hacs manifest file hacs.json.

When we change to these new constants we would also break the backward compatibility, and would need to adjust the homeassistant version that is required for new version of the JLR integration. Right?

[msp1974]

Yes that's correct. Not sure when these constants were added but we should make it earliest version that they are in.

[ismarslomic]

After checking quickly in HA core, it seems that some of these constants has existing for some time, but the deprecation warnings were introduced in v2024.1.

Btw: I see that the manifest file has not been touched for 4 years, but we do specify that minimum required HA version is 2022.10 in README. So I guess it just a miss from our side?

Due to changes in Home Assistant, this integration requires a minimum of HA v2022.10

[Troon]

UnitOfPressure enum introduced in home-assistant/core#81009
UnitOfLength enum introduced in home-assistant/core#81011

These constants were introduced in 2022.11.

[ismarslomic]

SourceType enum introduced in home-assistant/core#75892 and HA 2022.9
UnitOfTemperature enum introduced in home-assistant/core#81006 and HA 2022.11
UnitOfVolume enum introduced in home-assistant/core#81028 and HA 2022.11
UnitOfEnergy enum introduced in home-assistant/core#80998 and HA 2022.11

[ismarslomic]

Resolved in v2.2.5