chore(constants): migrate deprecated constants to enums #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msp1974 would you mind taking a look on this PR? |
|
Tested in fresh HA installation ( |
|
Looks good to me. |
|
Just noticed you have upped version to v3.0.0. As no change to functionality, can we make v2.2.5. |
|
I bumped to v3.0.0 because of new minimum requirement of HA version (considered as breaking for users of older HA version). But otherwise none other breaking changes. Up to you 😄 |
|
@msp1974 Should we release |
|
Use 2.2.5. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate deprecated HA constants to enums:
UnitOfPressureenum introduced in Migrate pressure units to an enum home-assistant/core#81009 and HA2022.11UnitOfLengthenum introduced in Migrate length units to an enum home-assistant/core#81011 and HA2022.11SourceTypeenum introduced in Add StrEnum for device_trackerSourceTypehome-assistant/core#75892 and HA2022.9UnitOfTemperatureenum introduced in Migrate temperature units to an enum home-assistant/core#81006 and HA2022.11UnitOfVolumeenum introduced in Migrate volume units to an enum home-assistant/core#81028 and HA2022.11UnitOfEnergyenum introduced in Migrate energy units to an enum home-assistant/core#80998 and HA2022.11Closes #106