Fixup a situation where Azure RBAC role ID was mis-identified #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2022
ferantivero
approved these changes
May 2, 2022
There was a problem hiding this comment.
thanks for bug fixing this @ckittel LGTM 🚀
only one comment to be considered.
| @@ -63,9 +63,6 @@ var acrPullRole = '${subscription().id}/providers/Microsoft.Authorization/roleDe | |||
| var managedIdentityOperatorRole = '${subscription().id}/providers/Microsoft.Authorization/roleDefinitions/f1a07417-d97a-45cb-824c-7a7467783830' | |||
There was a problem hiding this comment.
any desire to replicate the same design for this one and others?
There was a problem hiding this comment.
Not in this pass, as these didn't seem to have problems (still don't really know why) - and I'm keeping the changes scope to just those that I know had the issue. But yes, I think it would make sense to see if we can do this with the rest of them.
|
Thanks @ferantivero! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a deployment failure for AKS resource RBAC role assignments when using Azure RBAC for cluster access.
Also fixes typos in a couple descriptions.
Fixes: #310