Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aks-deploy.yaml file patching documentation issue #307

Closed
pallavgupta opened this issue Apr 29, 2022 · 2 comments · Fixed by #309
Closed

aks-deploy.yaml file patching documentation issue #307

pallavgupta opened this issue Apr 29, 2022 · 2 comments · Fixed by #309
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@pallavgupta
Copy link

pipe missing

Document link:- https://github.com/mspnp/aks-baseline/blob/main/06-aks-cluster.md

There is a pipe missing aks-deploy.yaml patching command in documentation. Currently command is throughing an error like:

pallav@Azure:~/aks-secure-baseline$ cat github-workflow/aks-deploy.yaml | \

sed "s#<resource-group-location>#eastus2#g" | \
sed "s#<resource-group-name>#rg-bu0001a0008#g" | \
sed "s#<geo-redundancy-location>#centralus#g" | \
sed "s#<cluster-spoke-vnet-resource-id>#${RESOURCEID_VNET_CLUSTERSPOKE_AKS_BASELINE}#g" | \
sed "s#<tenant-id-with-user-admin-permissions>#${TENANTID_K8SRBAC_AKS_BASELINE}#g" | \
sed "s#<azure-ad-aks-admin-group-object-id>#${AADOBJECTID_GROUP_CLUSTERADMIN_AKS_BASELINE}#g" | \
sed "s#<azure-ad-aks-a0008-group-object-id>#${AADOBJECTID_GROUP_A0008_READER_AKS_BASELINE}#g" | \
sed "s#<domain-name>#${DOMAIN_NAME_AKS_BASELINE}#g" \
sed "s#<bootstrapping-repo-https-url>#${GITOPS_REPOURL}#g"

sed: can't read sed: No such file or directory
sed: can't read s##https://github.com/pallavgupta/aks-baseline.git#g: No such file or directory
sed: couldn't write 153 items to stdout: Broken pipe

@ckittel ckittel added documentation Improvements or additions to documentation good first issue Good for newcomers labels Apr 29, 2022
@ckittel ckittel self-assigned this Apr 29, 2022
@ckittel
Copy link
Member

ckittel commented Apr 29, 2022

Thanks @pallavgupta for letting us know, fixed in #309

Btw, if you're currently going through this, just be aware of a known issue that was recently introduced (a regression) that is fixed in #306 -- I'm waiting on a final review before I merge that in.

@pallavgupta
Copy link
Author

@ckittel Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants