Extractor for exams supervision #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiodrg
force-pushed
the
feat/extractor-exams-supervision
branch
2 times, most recently
from
959212f
to
6a64bde
Compare
Preparing work before seperating event extractors from generic extractors
This extractor is a more specialised version of the extractor supporting specific features that do not make sense in generic extractors. For instance, an event extractor has customisable fields for the title and description (aka format-strings) which may be plaintext or HTML.
title/description in 'use strict' mode
A new class to be used in extractors and other modules that represent calendar events. It also supports recurring events and automatically calculates start/end datetimes accordingly with the recurrence period (see #110)
...) from event instances Addresses #111 as well
A flag that indicates wether the title and description are HTML or plaintext. This is necessary to properly encode the strings when generating the URLs to add events in google/microsoft/yahoo calendars
The new approach creates all the necessary DOM and adds event listeners automatically. It also supports the new CalEvent class to represent calendar events and generate the inline dropdowns from them
URL generation onclick The need for URL generation is because the recurrence period can be customised via the Modal interface. Therefore, the previous approach for static inline URLs does not suit
fabiodrg
force-pushed
the
feat/extractor-exams-supervision
branch
from
1248424
to
689022d
Compare
CalEvent class With this approach, it is possible to change the recurrence rules for 'one-click' events as well, as the URLs for dropdowns are generated dynamically. Whenever the date changes, the events recurrence period is updated accordingly
fabiodrg
force-pushed
the
feat/extractor-exams-supervision
branch
from
cefe0ee
to
e8339a1
Compare
This was
linked to
issues
Mar 28, 2022
msramalho
reviewed
Mar 29, 2022
Comment on lines
+156
to
+157
| startTime: new Date(`${date} ${startTime}`), | ||
| endTime: new Date(`${date} ${endTime}`), |
msramalho
reviewed
Mar 29, 2022
src/js/utils/dropdown.js
Outdated
| // add click action for the ICS download button | ||
| $dropdown.querySelector(".donwloadSingleIcs").addEventListener("click", (e) => { | ||
| const cal = ics("sigtools"); //creat ics instance |
There was a problem hiding this comment.
Suggested change
| const cal = ics("sigtools"); //creat ics instance | |
| const cal = ics("sigtools"); //create ics instance |
msramalho
reviewed
Mar 29, 2022
msramalho
reviewed
Mar 29, 2022
src/js/utils/modal.js
Outdated
Comment on lines
136
to
137
| for (const event of events) | ||
| event.setRecur(from, to); |
There was a problem hiding this comment.
Suggested change
| for (const event of events) | |
| event.setRecur(from, to); | |
| for (const event of events) { | |
| event.setRecur(from, to); | |
| } |
I do like one-liner ifs/fors but I think they make code harder to maintain, so this is more of a suggestion, I've seen a few other ifs/fors, and I also accept if you prefer them. feel free to ignore this suggestion
msramalho
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CalEvent(Extend the 'Extractor' class for calendar event extracts #107).EventExtractor, to distinguish between generic extractors and extractors that create calendar events.EventExtractorsupports the format-strings for title and description, customisable via options UI (Extend the 'Extractor' class for calendar event extracts #107).CalEventwith the formatted strings to separate the semantics of extractors and events. Generating UI only needs the events objects with this approachcalendar.jsCalEventclassCalEventclassPreview