-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for longer passcodes #49
Comments
Yes, six-digit passcode needs to custom UI. I think six digits is reasonable. Let me try to implement this. However, providing options to choose from is more flexible. |
What I was expecting as a user was the same interface as I get when creating my passcode for the iPhone (i.e. it defaults to 4-digit, but you can select an arbitrary-number-of-digit passcode or an alphanumeric one from the same screen). Is there some reason why Apple doesn't expose an API for generating this screen? |
Unfortunately, no handful API provided from Apple. Therefore, we have to implement the function by ourselves. |
@raxod502 Are you working on this? I saw you fork the repo. |
@mssun It's one of the issues that I would be interested in finding a solution for. But because I don't have much experience with Swift or Xcode, I'm holding off on working on this in favor of looking at other (simpler) parts. |
Sure, thanks for you contributions.
…On Tue, Mar 7, 2017 at 4:05 PM, Radon Rosborough ***@***.***> wrote:
@mssun <https://github.com/mssun> It's one of the issues that I would be
interested in finding a solution for. But because I don't have much
experience with Swift or Xcode, I'm holding off on working on this in favor
of looking at other (simpler) parts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNieJslKSGTnSWbPsl5MjmqLW0pQfNzks5rjfC5gaJpZM4MUsHi>
.
|
Hi @raxod502 , I saw you try to change to ten passcode. Is everything OK? I thought the passcode lock UI only support four digits. For more digits, I guess you should customize the lock UI. |
@mssun Although the UI doesn't look right, it works just fine with 10 digits. (There are four dots, but it still waits for six more digits after those dots become filled in.) |
How about I closing this issue right now? Maybe in the next release, we may seek methods to customize the UI for better experience. |
If you'd like "open" to mean "is a current goal" in this issue tracker, then that sounds perfectly reasonable. |
What else is left to do? |
As far as I know, the feature is not implemented. So, we're looking for a better passcode lock framework as per #122 (comment). |
Pass v0.3.1(12) supports longer passwords now! I implemented a simple passcode lock (with an ugly UI). =D |
I always use at least ten digits for my iPhone passcodes. It would be nice to have support for this in Pass for iOS.
Relevant: yankodimitrov/SwiftPasscodeLock#55
(But the issue might be upstream.)
The text was updated successfully, but these errors were encountered: