Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for longer passcodes #49

Closed
raxod502 opened this issue Mar 6, 2017 · 13 comments
Closed

Support for longer passcodes #49

raxod502 opened this issue Mar 6, 2017 · 13 comments

Comments

@raxod502
Copy link
Contributor

raxod502 commented Mar 6, 2017

I always use at least ten digits for my iPhone passcodes. It would be nice to have support for this in Pass for iOS.

Relevant: yankodimitrov/SwiftPasscodeLock#55

(But the issue might be upstream.)

@mssun
Copy link
Owner

mssun commented Mar 6, 2017

Yes, six-digit passcode needs to custom UI. I think six digits is reasonable. Let me try to implement this. However, providing options to choose from is more flexible.

@raxod502
Copy link
Contributor Author

raxod502 commented Mar 7, 2017

What I was expecting as a user was the same interface as I get when creating my passcode for the iPhone (i.e. it defaults to 4-digit, but you can select an arbitrary-number-of-digit passcode or an alphanumeric one from the same screen). Is there some reason why Apple doesn't expose an API for generating this screen?

@mssun
Copy link
Owner

mssun commented Mar 7, 2017

Unfortunately, no handful API provided from Apple. Therefore, we have to implement the function by ourselves.

@mssun
Copy link
Owner

mssun commented Mar 7, 2017

@raxod502 Are you working on this? I saw you fork the repo.

@raxod502
Copy link
Contributor Author

raxod502 commented Mar 8, 2017

@mssun It's one of the issues that I would be interested in finding a solution for. But because I don't have much experience with Swift or Xcode, I'm holding off on working on this in favor of looking at other (simpler) parts.

@mssun
Copy link
Owner

mssun commented Mar 8, 2017 via email

@mssun
Copy link
Owner

mssun commented Mar 24, 2017

Hi @raxod502 , I saw you try to change to ten passcode. Is everything OK? I thought the passcode lock UI only support four digits. For more digits, I guess you should customize the lock UI.

@raxod502
Copy link
Contributor Author

@mssun Although the UI doesn't look right, it works just fine with 10 digits. (There are four dots, but it still waits for six more digits after those dots become filled in.)

@mssun
Copy link
Owner

mssun commented Mar 24, 2017

How about I closing this issue right now? Maybe in the next release, we may seek methods to customize the UI for better experience.

@raxod502
Copy link
Contributor Author

If you'd like "open" to mean "is a current goal" in this issue tracker, then that sounds perfectly reasonable.

@posix4e
Copy link

posix4e commented Oct 25, 2017

What else is left to do?

@raxod502
Copy link
Contributor Author

As far as I know, the feature is not implemented. So, we're looking for a better passcode lock framework as per #122 (comment).

@yishilin14
Copy link
Collaborator

yishilin14 commented Apr 11, 2018

Pass v0.3.1(12) supports longer passwords now! I implemented a simple passcode lock (with an ugly UI). =D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants