-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aave v2 migration #106
Aave v2 migration #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note on the test case - given that they are both fairly similar in setup, it might be cleaner to group the setup into the 'beforeEach' or a 'setup' function that returns the right props. We can also test more properties in each of these test cases..
1f83198
to
598a6e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably provide less or group unit tests for the arg checking and more for integration tests. For example verifying that checkBalance
works correctly after the migration, checking that deposit
and withdraw
(or swapping) also work correctly after the migration - there should be some cases for that in the file. You could do this all in 1 test case. I think integration tests are most powerful when it comes to these things.
Please find attached the current interface for ILendingPool V2 |
444f69a
to
2671e31
Compare
Upgrades Aave Integration Contract to support a migration to Aave v2.
Assumptions