Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aave v2 migration #106

Closed
wants to merge 1 commit into from
Closed

Aave v2 migration #106

wants to merge 1 commit into from

Conversation

shapeshed
Copy link
Contributor

@shapeshed shapeshed commented Sep 8, 2020

Upgrades Aave Integration Contract to support a migration to Aave v2.

Assumptions

  • The AToken interface will stay the same
  • The decimals on AToken will remain the same
  • The AToken v2 address will change
  • The Aave Platform address may change
  • The referral code will stay the same

@shapeshed shapeshed changed the base branch from master to beta September 8, 2020 12:42
@shapeshed shapeshed changed the base branch from beta to master September 8, 2020 12:42
Copy link
Contributor

@alsco77 alsco77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note on the test case - given that they are both fairly similar in setup, it might be cleaner to group the setup into the 'beforeEach' or a 'setup' function that returns the right props. We can also test more properties in each of these test cases..

@shapeshed shapeshed force-pushed the aave-v2-migration branch 3 times, most recently from 1f83198 to 598a6e2 Compare September 8, 2020 17:47
@shapeshed shapeshed marked this pull request as ready for review September 8, 2020 18:30
Copy link
Contributor

@alsco77 alsco77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably provide less or group unit tests for the arg checking and more for integration tests. For example verifying that checkBalance works correctly after the migration, checking that deposit and withdraw (or swapping) also work correctly after the migration - there should be some cases for that in the file. You could do this all in 1 test case. I think integration tests are most powerful when it comes to these things.

@The-3D
Copy link

The-3D commented Sep 24, 2020

Please find attached the current interface for ILendingPool V2
ILendingPool.zip

@alsco77 alsco77 closed this Oct 12, 2020
@alsco77 alsco77 deleted the aave-v2-migration branch October 12, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants