Vault deployment #58
Merged
Vault deployment #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naddison36
commented
Oct 20, 2022
•
naddison36
commented
- Added config for new vaults on mainnet
- Hardhat tasks to snap basic vault and convex meta vault details
- Hardhat task refactoring
doncesarts
reviewed
Oct 20, 2022
| @@ -149,11 +149,13 @@ export async function deployConvex3CrvLiquidatorVault( | |||
| `Convex3CrvLiquidatorVault ${name} (${symbol})`, | |||
| constructorArguments, | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
is getFactoryMetapoolLinkAddresses used?
There was a problem hiding this comment.
no, Curve3CrvMetapoolCalculatorLibrary and Curve3CrvFactoryMetapoolCalculatorLibrary have the same ABI so I could get away with just using getMetapoolLinkAddresses even through BUSD and FRAX are Curve Metapools.
The logic for picking the correct library address is in the convex-3crv-vault-deploy task at
metavaults/tasks/convex3CrvVault.ts
Line 231 in f3e5b18
doncesarts
reviewed
Oct 20, 2022
| @@ -52,3 +52,45 @@ subtask("curve-add", "Add liquidity to Curve 3Pool") | |||
| task("curve-add").setAction(async (_, __, runSuper) => { | |||
| await runSuper() | |||
| }) | |||
|
|
|||
| subtask("curve-swap", "Swap tokens using Curve 3Pool") | |||
There was a problem hiding this comment.
Thanks. I used that yesterday to swap DAI for USDC.
doncesarts
reviewed
Oct 20, 2022
| assetSymbol: ThreeCRV.symbol, | ||
| } | ||
|
|
||
| export const mvUSDC3PCV: Token = { |
There was a problem hiding this comment.
@toniocodo you might want this :p
doncesarts
approved these changes
Oct 20, 2022
naddison36
added a commit
that referenced
this pull request
Oct 21, 2022
* Vault deployment (#58) * chore: added config for new vaults on mainnet * chore: more Hardhat task refactoring * chore: Hardhat tasks to snap basic vault and convex meta vault details * chore: bump package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.