Skip to content
This repository has been archived by the owner on May 17, 2022. It is now read-only.

Add check_skip example #6

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

GuillaumeFavelier
Copy link
Contributor

This PR follows #4 (comment) and adds a basic example on .github/workflows plus some explanations in the Readme.

@GuillaumeFavelier
Copy link
Contributor Author

Should I add the trigger:

  pull_request:
    branches: [ master ]

in .github/workflows/fail-safe-commit-filter-separator-should-success.yml ?

Let me know what you think @mstachniuk

@@ -116,6 +116,38 @@ If you want to use multiple filters at once, it's possible to separate them with
[...]
----

=== Job to check skip message

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would put this one at the top, above all other methods. It behaves most similarly to how ci skip does on all other platforms with fewer drawbacks.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment. Let's merge as it is for now. The example is a little bit long what can be a problem for first-time users.

@mstachniuk
Copy link
Owner

Let's merge as it is. I will change in all yamls to:

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

what is the best setup in my opinion.

@mstachniuk mstachniuk merged commit 019203e into mstachniuk:master Nov 24, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the enh/example branch November 25, 2020 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants