Fix derivative scaling #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @justinthomas, thanks for this PR. If I remember correctly, the formulas given at https://pages.mtu.edu/~shene/COURSES/cs3621/NOTES/spline/B-spline/bspline-derv.html only work if the knot vector is scaled to [0, 1]. I'll have a look at your changes. Again, thank your for your contributions. |
msteinbeck
reviewed
May 5, 2020
msteinbeck
reviewed
May 5, 2020
|
I checked your code and it looks good to me. Could you please fix the two comments listed above? Your test case is very good, thanks for that. It looks like scaling the knot vector is not necessary. I assume that my previous issue wasn't related to scaling but to another error. However, I'll merge your changes and remove scaling by my own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162