Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FLTK example build #183

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Conversation

julianoes
Copy link
Contributor

@julianoes julianoes commented Sep 19, 2021

This fixes a build error I get when trying to build the C++ FTLK
example:

[ 36%] Building CXX object examples/cxx/fltk/CMakeFiles/demo-ui.dir/demo.cxx.o
In file included from tinyspline/build/examples/cxx/fltk/demo.h:9,
                 from tinyspline/build/examples/cxx/fltk/demo.cxx:3:
tinyspline/examples/cxx/fltk/eval.h:2:10: fatal error: tinysplinecxx.h: No such file or directory
    2 | #include "tinysplinecxx.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

This is on Arch Linux with:
Cmake 3.21.2
GCC 11.1.0
fltk 1.3.7-1

This fixes a build error I get when trying to build the C++ FTLK
example:

[ 36%] Building CXX object examples/cxx/fltk/CMakeFiles/demo-ui.dir/demo.cxx.o
In file included from tinyspline/build/examples/cxx/fltk/demo.h:9,
                 from tinyspline/build/examples/cxx/fltk/demo.cxx:3:
tinyspline/examples/cxx/fltk/eval.h:2:10: fatal error: tinysplinecxx.h: No such file or directory
    2 | #include "tinysplinecxx.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
@msteinbeck
Copy link
Owner

Hi @julianoes,

thank you for this PR. I'm wondering why it's necessary to link tinysplinecxx into demo-ui. Do you have any ideas?

@msteinbeck
Copy link
Owner

I found the reason: demo.fl includes eval.h and sample.h. Anyhow, I'm wondering why I hadn't issues building the example.

@msteinbeck msteinbeck merged commit c83a30b into msteinbeck:master Sep 19, 2021
@julianoes julianoes deleted the pr-fix-include branch September 19, 2021 17:02
@julianoes
Copy link
Contributor Author

Thanks for merging.

Anyhow, I'm wondering why I hadn't issues building the example.

Maybe the library was installed in the system already?

@msteinbeck
Copy link
Owner

Maybe the library was installed in the system already?

Oh yes, you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants