-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assertion failure in GetInvInt() for 96kHz input + AACENC_BITRATEMODE: 5 #17
Comments
Try the fix-high-samplerate-short-blocks branch - this fixes the crash for me. The fix involves redistributing some coefficients, and doing that probably does affect the psychoacoustic quality/bitrate tradeoff so I'm a little weary about which tradeoff is the best. (OTOH, anything that doesn't crash probably is better than what we have right now.) |
A probably even better solution is available in the "extend-getinvint" branch - which just makes GetInvInt support larger values. |
A probably even better solution is available in the "extend-getinvint" branch - which just makes GetInvInt support larger values. Yeah, I thought about that as an obvious workaround, but I wondered if this setting was out of assumption of psy-logic in the first place. |
Yeah, I pointed out the issue to Fraunhofer, and they told me that these coefficients are set in the spec and thus can't be adjusted. As far as I can see, GetInvInt will need to be able to handle any coefficient *3/2, and only these ones that are 36 exceed the current GetInvInt table, and their initial suggestion also was to just extend the table. For their final fix one can only wait for a future code drop into a future android release. |
As the title says, when trying to encode 96kHz input with AACENC_BITRATEMODE: 5 (VBR), fdk-aac crashes with an assertion failure.
Stack trace is as follows:
The text was updated successfully, but these errors were encountered: