Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Changed tests to use done_testing() rather than pre-counted tests.

The skips are causing lots of test failures.  Perhaps there is a more
elegant way to handle this,but this should tide us over until a
more suitable fix is applied.
  • Loading branch information...
commit 22dc15650a94d4f971de1ecf7ebe33b1c3744b41 1 parent fc1e4d2
Mark A. Stratman authored

Showing 2 changed files with 6 additions and 9 deletions. Show diff stats Hide diff stats

  1. +2 7 t/01.methods.t
  2. +4 2 t/pod-coverage.t
9 t/01.methods.t
... ... @@ -1,4 +1,4 @@
1   -use Test::More tests => 22;
  1 +use Test::More;
2 2 use lib '../lib';
3 3
4 4 BEGIN {
@@ -7,12 +7,6 @@ BEGIN {
7 7
8 8 diag( "Testing DateTime::Format::Human::Duration $DateTime::Format::Human::Duration::VERSION" );
9 9
10   -# plan skip_all => 'DateTime required for creating DateTime object and durations' if $@;
11   -# That fails under Test::More 0.70 like so:
12   -# You tried to plan twice at t/01.methods.t line 11.
13   -# Looks like you planned 22 tests but only ran 1.
14   -# Looks like your test died just after 1.
15   -
16 10 SKIP: {
17 11 eval 'use DateTime';
18 12 skip 'DateTime required for creating DateTime object and durations', 22 if $@;
@@ -67,3 +61,4 @@ SKIP: {
67 61
68 62 };
69 63
  64 +done_testing();
6 t/pod-coverage.t
... ... @@ -1,10 +1,12 @@
1 1 #!perl -T
2 2
3   -use Test::More 'tests' => 1;
  3 +use Test::More;
4 4 eval 'use Test::Pod::Coverage 1.04';
5 5 plan skip_all => 'Test::Pod::Coverage 1.04 required for testing POD coverage' if $@;
6 6
7 7 Test::Pod::Coverage::pod_coverage_ok( "DateTime::Format::Human::Duration", { 'trustme' => [qr/^(new)$/,], } );
8 8
9 9 # Locale.pm, es.pm, and fr.pm don;t have POD
10   -# all_pod_coverage_ok();
  10 +# all_pod_coverage_ok();
  11 +
  12 +done_testing();

0 comments on commit 22dc156

Please sign in to comment.
Something went wrong with that request. Please try again.