Permalink
Browse files

Changed tests to use done_testing() rather than pre-counted tests.

The skips are causing lots of test failures.  Perhaps there is a more
elegant way to handle this,but this should tide us over until a
more suitable fix is applied.
  • Loading branch information...
1 parent fc1e4d2 commit 22dc15650a94d4f971de1ecf7ebe33b1c3744b41 @mstratman committed Apr 11, 2012
Showing with 6 additions and 9 deletions.
  1. +2 −7 t/01.methods.t
  2. +4 −2 t/pod-coverage.t
View
9 t/01.methods.t
@@ -1,4 +1,4 @@
-use Test::More tests => 22;
+use Test::More;
use lib '../lib';
BEGIN {
@@ -7,12 +7,6 @@ BEGIN {
diag( "Testing DateTime::Format::Human::Duration $DateTime::Format::Human::Duration::VERSION" );
-# plan skip_all => 'DateTime required for creating DateTime object and durations' if $@;
-# That fails under Test::More 0.70 like so:
-# You tried to plan twice at t/01.methods.t line 11.
-# Looks like you planned 22 tests but only ran 1.
-# Looks like your test died just after 1.
-
SKIP: {
eval 'use DateTime';
skip 'DateTime required for creating DateTime object and durations', 22 if $@;
@@ -67,3 +61,4 @@ SKIP: {
};
+done_testing();
View
6 t/pod-coverage.t
@@ -1,10 +1,12 @@
#!perl -T
-use Test::More 'tests' => 1;
+use Test::More;
eval 'use Test::Pod::Coverage 1.04';
plan skip_all => 'Test::Pod::Coverage 1.04 required for testing POD coverage' if $@;
Test::Pod::Coverage::pod_coverage_ok( "DateTime::Format::Human::Duration", { 'trustme' => [qr/^(new)$/,], } );
# Locale.pm, es.pm, and fr.pm don;t have POD
-# all_pod_coverage_ok();
+# all_pod_coverage_ok();
+
+done_testing();

0 comments on commit 22dc156

Please sign in to comment.