Circleci to actions #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexNDRmac
commented
Oct 5, 2023
AlexNDRmac
commented
- Migrated from CircleCi to Github Actions Switch from circle CI to Github Actions #13
- Updated Readme (added license block)
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
mstruebing
requested changes
Oct 6, 2023
.github/workflows/main.yml
Outdated
| @@ -0,0 +1,40 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
Can we name the file ci.yml as well?
.github/workflows/main.yml
Outdated
| - name: Setup Go | ||
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: 1.19 |
There was a problem hiding this comment.
In the go.mod file we are using 1.12 currently.
Can you either update this here to also use 1.12 (not sure this is still supported by this action) or update the go version in the go.mod file?
There was a problem hiding this comment.
With go 1.12 tests was failed, so I've bumped version, because test package want's 1.20.
I'll try to update go version to 1.20
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
|
all have done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.