Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispensing: search for items by code #3130

Closed
mark-prins opened this issue Sep 18, 2020 · 2 comments · Fixed by #3146
Closed

Dispensing: search for items by code #3130

mark-prins opened this issue Sep 18, 2020 · 2 comments · Fixed by #3146
Labels
Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: high Type: Feature From a new button to whole new systems

Comments

@mark-prins
Copy link
Contributor

Description

When dispensing, it is possible to search for items by description:

Screen Shot 2020-09-18 at 1 53 23 PM

But you cannot search by code. Would it be possible to expand the search, so that it also searches by code:

Screen Shot 2020-09-18 at 1 53 45 PM

The prescription.js currently uses the search 'name CONTAINS[c] $0', itemSearchTerm
Include code as well?
@mark-prins mark-prins added the Type: Feature From a new button to whole new systems label Sep 18, 2020
@josh-griffin
Copy link
Contributor

Yeah, should just need to change name CONTAINS[c] $0 || code CONTAINS[c] $0 - this need to be in release soon?

@mark-prins
Copy link
Contributor Author

a client raised it as a concern, so I might pop it in so that we can include in v6.
Should be fairly low impact

@josh-griffin josh-griffin mentioned this issue Sep 21, 2020
Closed
14 tasks
@josh-griffin josh-griffin added Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: high labels Sep 21, 2020
@mark-prins mark-prins mentioned this issue Sep 25, 2020
Merged
1 task
mark-prins added a commit that referenced this issue Sep 25, 2020
@mark-prins
Merge pull request #3146 from openmsupply/#3130-dispensing-search-for…
a9ad1d9 
…-items-by-code

allow filtering by code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: high Type: Feature From a new button to whole new systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3130 allow filtering by code msupply-foundation/mobile
2 participants
@mark-prins @josh-griffin