Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modals should be full screen #3209

Closed
josh-griffin opened this issue Nov 19, 2020 · 1 comment
Closed

Modals should be full screen #3209

josh-griffin opened this issue Nov 19, 2020 · 1 comment
Assignees
@josh-griffin
Labels
Bug: development Bug was found and believed to only be in development branches Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: high
Projects
mobile

Comments

@josh-griffin
Copy link
Contributor

Describe the bug

StocktakeBatchModal and other modals should be full screen

To reproduce

Steps to reproduce the behavior:

  1. Go to StocktakeBatchModal
  2. See error

Expected behaviour

Modals should be full screen, you can't click behind it and from observing people they often get annoyed

Proposed Solution

use fullScreen prop

Version and device info

  • App version: 6.0RC10
  • Tablet model:
  • OS version:

Additional context

N/a
@josh-griffin josh-griffin mentioned this issue Nov 19, 2020
Merged
1 task
@josh-griffin josh-griffin self-assigned this Nov 20, 2020
@josh-griffin josh-griffin added Bug: development Bug was found and believed to only be in development branches Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: high labels Nov 20, 2020
@josh-griffin josh-griffin added this to To do in mobile via automation Nov 20, 2020
@josh-griffin josh-griffin added this to the 6.0.0 milestone Nov 20, 2020
josh-griffin added a commit that referenced this issue Nov 21, 2020
@josh-griffin
Merge pull request #3212 from openmsupply/#3209-fullscreen-modals
22946d2
@josh-griffin
Copy link
Contributor Author

Closed by #3212

mobile automation moved this from To do to Needs testing Nov 21, 2020
@josh-griffin josh-griffin mentioned this issue Nov 26, 2020
Closed
14 tasks
@josh-griffin josh-griffin moved this from Needs testing to Done in mobile Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josh-griffin josh-griffin

Labels
Bug: development Bug was found and believed to only be in development branches Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: high
Projects
mobile
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josh-griffin