Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncing empty name records #3237

Closed
josh-griffin opened this issue Nov 24, 2020 · 0 comments
Closed

Syncing empty name records #3237

josh-griffin opened this issue Nov 24, 2020 · 0 comments
Assignees
@josh-griffin
Labels
Bug: production Bug was found or believed to be in a live release Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: release blocker
Projects
mobile

Comments

@josh-griffin
Copy link
Contributor

Describe the bug

This line here: https://github.com/openmsupply/mobile/blob/a9ad1d9c2b48cc305804d4caefbd90146fccbb2a/src/sync/outgoingSyncUtils.js#L78

Means sync will try to sync an empty record and breaks sync

To reproduce

Not sure! This should never occur, but if it does.. 🤷

Expected behaviour

N/A

Proposed Solution

Filter the sync out queue of name types which aren't patients

Version and device info

  • App version: N/A
  • Tablet model: N/A
  • OS version: N/A

Additional context

N/A
@josh-griffin josh-griffin mentioned this issue Nov 24, 2020
Merged
1 task
josh-griffin added a commit that referenced this issue Nov 25, 2020
@josh-griffin
Merge pull request #3240 from openmsupply/#3237-dont-sync-out-non-pat…
f42a03c 
…ient-names

#3237 Dont sync out non patient names
@josh-griffin josh-griffin self-assigned this Nov 25, 2020
@josh-griffin josh-griffin added Bug: production Bug was found or believed to be in a live release Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Module: Sync Priority: release blocker labels Nov 25, 2020
@josh-griffin josh-griffin added this to To do in mobile via automation Nov 25, 2020
@josh-griffin josh-griffin added this to the 6.0.0 milestone Nov 25, 2020
@josh-griffin josh-griffin moved this from To do to Needs testing in mobile Nov 25, 2020
@josh-griffin josh-griffin mentioned this issue Nov 26, 2020
Closed
14 tasks
@josh-griffin josh-griffin moved this from Needs testing to Done in mobile Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josh-griffin josh-griffin

Labels
Bug: production Bug was found or believed to be in a live release Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: release blocker
Projects
mobile
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josh-griffin