This repository has been archived by the owner on Nov 15, 2019. It is now read-only.
Skip agents with empty server url. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,7 @@ | |||
|
|
|||
| if agent['server_url'].nil? | |||
| Chef::Log.fatal "You need to setup the server url for agent #{name}" | |||
| next | |||
There was a problem hiding this comment.
I don't it is the right way to ignore incorrect configured agents. Instead of next an exception should be raised with the same information as the log entry.
danieljimenez
referenced
this pull request
in foreflight/chef-teamcity
Nov 27, 2015
added windows support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip agents without a server URL to avoid throwing an
undefined method '+' for nil:NilClasserror when building the download URL. Also avoids creating users, groups, ... for invalid agents.